... but fail with msvc && stdlib=libc++.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
This looks sensible to me. (I would presume that some amount of other windows/msvc specific XFAILs aren't right for stdlib=msvc - I presume you don't run all of the libc++ tests regularly in that configuration, only some subset?)
Comment Actions
Yes, we run a subset - although I'm trying to get folks motivated to grow that subset. We have an external control mechanism with a list of a few hundred XFAILs and a couple of dozen SKIPPEDs (which are effectively UNSUPPORTED except that we track them differently.)
Comment Actions
This was committed in rGb5bada6f85ce6789415d8b9844b6fd3a26d5408f. (@CaseyCarter, the magic keyword is Differential Revision: <url>, not Differential Review: ...)