This is an archive of the discontinued LLVM Phabricator instance.

[libcxx][test] Narrow XFAIL for tests that pass with `msvc && stdlib=msvc`
ClosedPublic

Authored by CaseyCarter on Jan 25 2022, 2:14 PM.

Details

Reviewers
Quuxplusone
mstorsjo
ldionne
Group Reviewers
Restricted Project
Summary

... but fail with msvc && stdlib=libc++.

Diff Detail

Event Timeline

CaseyCarter requested review of this revision.Jan 25 2022, 2:14 PM
CaseyCarter created this revision.
Herald added 1 blocking reviewer(s): Restricted Project. · View Herald TranscriptJan 25 2022, 2:14 PM
mstorsjo accepted this revision.Jan 25 2022, 2:28 PM
mstorsjo added a subscriber: mstorsjo.

This looks sensible to me. (I would presume that some amount of other windows/msvc specific XFAILs aren't right for stdlib=msvc - I presume you don't run all of the libc++ tests regularly in that configuration, only some subset?)

ldionne accepted this revision.Jan 25 2022, 3:38 PM
This revision is now accepted and ready to land.Jan 25 2022, 3:38 PM

This looks sensible to me. (I would presume that some amount of other windows/msvc specific XFAILs aren't right for stdlib=msvc - I presume you don't run all of the libc++ tests regularly in that configuration, only some subset?)

Yes, we run a subset - although I'm trying to get folks motivated to grow that subset. We have an external control mechanism with a list of a few hundred XFAILs and a couple of dozen SKIPPEDs (which are effectively UNSUPPORTED except that we track them differently.)

mstorsjo closed this revision.Jan 26 2022, 12:50 PM

This was committed in rGb5bada6f85ce6789415d8b9844b6fd3a26d5408f. (@CaseyCarter, the magic keyword is Differential Revision: <url>, not Differential Review: ...)

This was committed in rGb5bada6f85ce6789415d8b9844b6fd3a26d5408f. (@CaseyCarter, the magic keyword is Differential Revision: <url>, not Differential Review: ...)

<sarcasm>❤️ Phabricator!</sarcasm>