Page MenuHomePhabricator
Differential D118192

[libcxx] Allow using thread safety annotations in MinGW mode
ClosedPublic
Actions

Authored by mstorsjo on Jan 25 2022, 2:05 PM.

Details

Reviewers
ldionne
Group Reviewers
Restricted Project
Commits
rGde5d38ef2de6: [libcxx] Allow using thread safety annotations in MinGW mode
Summary

These were omitted in all Windows configurations, but it turns out
that they work just fine in MinGW mode.

This allows converting a couple cases of "XFAIL: LIBCXX-WINDOWS-FIXME"
into "XFAIL: msvc" as the bug is specific to MSVC mode (clang-cl).

Diff Detail

Event Timeline

mstorsjo requested review of this revision.Jan 25 2022, 2:05 PM
mstorsjo created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptJan 25 2022, 2:05 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Harbormaster completed remote builds in B145600: Diff 403035.Jan 25 2022, 5:16 PM
ldionne accepted this revision.Jan 27 2022, 2:00 PM
This revision is now accepted and ready to land.Jan 27 2022, 2:00 PM
Closed by commit rGde5d38ef2de6: [libcxx] Allow using thread safety annotations in MinGW mode (authored by mstorsjo). · Explain WhyJan 28 2022, 1:22 AM
This revision was automatically updated to reflect the committed changes.
mstorsjo added a commit: rGde5d38ef2de6: [libcxx] Allow using thread safety annotations in MinGW mode.

Revision Contents
Changeset List

Diff 403922

View Options

libcxx/include/__config

Loading...
View Options

libcxx/test/libcxx/thread/thread.mutex/thread_safety_lock_guard.pass.cpp

Loading...
View Options

libcxx/test/libcxx/thread/thread.mutex/thread_safety_lock_unlock.pass.cpp

Loading...
View Options

libcxx/test/libcxx/thread/thread.mutex/thread_safety_missing_unlock.fail.cpp

Loading...
View Options

libcxx/test/libcxx/thread/thread.mutex/thread_safety_requires_capability.pass.cpp

Loading...