This is an archive of the discontinued LLVM Phabricator instance.

[LNT] Fix the graph page to show multiple metrics for the same test
ClosedPublic

Authored by kpdev42 on Jan 25 2022, 11:25 AM.

Details

Summary

Note: request.args is a dict and duplicate keys are ignored.
Currently the plot args have the following format plot.unused=m.t.f where unused is the test id.
If you select few metrics for the same test (for example compile_time and execution_time) on the Run page and click Graph,
the URL will look like /db_default/v4/nts/graph?plot.958=5.958.2&plot.958=5.958.3
The second plot argument with the same key will be ignored. This patch fixes this issue.

OS Laboratory. Huawei Russian Research Institute. Saint-Petersburg

Diff Detail

Repository
rLNT LNT

Event Timeline

kpdev42 created this revision.Jan 25 2022, 11:25 AM
kpdev42 requested review of this revision.Jan 25 2022, 11:25 AM
cmatthews accepted this revision.Jan 26 2022, 10:03 AM

LGTM. Thanks!

This revision is now accepted and ready to land.Jan 26 2022, 10:03 AM