Fix running orc-rt tests with LLVM_BUILD_EXTERNAL_COMPILER_RT

[benlangmuir]

Summary

Add missing dependency on llvm-jitlink when building compiler-rt with LLVM_BUILD_EXTERNAL_COMPILER_RT. Previously we would non-deterministically fail the tests due to the missing binary.

rdar://87247681

[lhames]

LGTM!

Does check-orc-rt need to be added to COMPILER_RT_TEST_SUITES too? I guess not, otherwise we wouldn't have seen this missing dependency in the first place?

[benlangmuir]

Does check-orc-rt need to be added to COMPILER_RT_TEST_SUITES too? I guess not, otherwise we wouldn't have seen this missing dependency in the first place?

It doesn't affect check-compiler-rt, because check-compiler-rt actually wraps the check-all target from compiler-rt rather than depending on the individual components defined in this file. I think we only need to add individual components here if it's useful to someone.

There's actually a whole bunch of check- targets in compiler-rt that are not reflected here, so I'd prefer to call it a separate issue if we do add more:

check-asan-${platform}-${arch}
check-builtins
check-crt
check-fuzzer-${platform}-${arch}
check-fuzzer-${stdlib_name}-${arch}
check-fuzzer-unit
check-hwasan-lam
check-interception
check-memprof
check-memprof-dynamic
check-orc-rt
check-scudo
check-scudo_standalone
check-shadowcallstack
check-tsan-${platform}-${arch}
check-tsan-dynamic
check-ubsan-${test_mode}-${platform}-${arch}
check-xray

clang/runtime/CMakeLists.txt

add_custom_target(${runtime}
       DEPENDS compiler-rt-configure
       WORKING_DIRECTORY ${BINARY_DIR}
       VERBATIM USES_TERMINAL)
   endforeach()
 
   if(LLVM_INCLUDE_TESTS)
     # Add binaries that compiler-rt tests depend on.
     set(COMPILER_RT_TEST_DEPENDENCIES
-      FileCheck count not llvm-nm llvm-objdump llvm-symbolizer)
+      FileCheck count not llvm-nm llvm-objdump llvm-symbolizer llvm-jitlink)
 
     # Add top-level targets for various compiler-rt test suites.
     set(COMPILER_RT_TEST_SUITES check-fuzzer check-asan check-hwasan check-asan-dynamic check-dfsan
       check-lsan check-msan check-sanitizer check-tsan check-ubsan check-ubsan-minimal
       check-profile check-cfi check-cfi-and-supported check-safestack check-gwp_asan)
     foreach(test_suite ${COMPILER_RT_TEST_SUITES})
       get_ext_project_build_command(run_test_suite ${test_suite})
       add_custom_target(${test_suite}