Return false from ShouldShrinkFPConstant()
(on top of https://reviews.llvm.org/D115690)
Paths
| Differential D117927
[SystemZ] Don't shrink FP constants ClosedPublic Authored by jonpa on Jan 21 2022, 1:50 PM.
Details
Summary Return false from ShouldShrinkFPConstant() (on top of https://reviews.llvm.org/D115690)
Diff Detail Event Timeline
jonpa marked an inline comment as done. Comment ActionsUpdated per review (see comment below).
This revision is now accepted and ready to land.Jan 27 2022, 11:53 AM This revision was landed with ongoing or failed builds.Jan 27 2022, 2:15 PM Closed by commit rG9ca9fee6e844: [SystemZ] Don't shrink 64-bit FP constants. (authored by jonpa). · Explain Why This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 402100 llvm/lib/Target/SystemZ/SystemZISelLowering.h
llvm/test/CodeGen/SystemZ/args-07.ll
llvm/test/CodeGen/SystemZ/call-zos-01.llllvm/test/CodeGen/SystemZ/fp-const-04.ll
llvm/test/CodeGen/SystemZ/fp-const-05.ll
llvm/test/CodeGen/SystemZ/fp-const-07.ll
llvm/test/CodeGen/SystemZ/fp-conv-10.ll
llvm/test/CodeGen/SystemZ/fp-conv-12.ll
llvm/test/CodeGen/SystemZ/fp-strict-conv-10.ll
llvm/test/CodeGen/SystemZ/fp-strict-conv-12.ll
llvm/test/CodeGen/SystemZ/vector-constrained-fp-intrinsics.ll
|
Hmm. For the 128-bit constant case, I think the lxdb remains preferable - this new version now has two instructions, which most likely will be worse. So maybe in that case we still should try to shrink?