Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
LGTM with a minor nit
libc/include/llvm-libc-types/tm.h | ||
---|---|---|
10 | is there a reason behind the trailing underscores? It doesn't match the format of the other header guards. |
libc/include/llvm-libc-types/tm.h | ||
---|---|---|
10 | We need the prefix as we cannot pollute the namespace. But, the trailing underscores are just my personal choice. We can remove if there is a reason we should not have them. The normal header guard rule does not apply here (and is not good enough because of namespace pollution) as these are part of the public headers and not internal libc headers. |
is there a reason behind the trailing underscores? It doesn't match the format of the other header guards.