This is an archive of the discontinued LLVM Phabricator instance.

[libc] Move the remaining public types to their own type headers.
ClosedPublic

Authored by sivachandra on Jan 20 2022, 2:28 PM.

Diff Detail

Event Timeline

sivachandra created this revision.Jan 20 2022, 2:28 PM
sivachandra requested review of this revision.Jan 20 2022, 2:28 PM
michaelrj accepted this revision.Jan 20 2022, 2:32 PM

LGTM with a minor nit

libc/include/llvm-libc-types/tm.h
10

is there a reason behind the trailing underscores? It doesn't match the format of the other header guards.

This revision is now accepted and ready to land.Jan 20 2022, 2:32 PM
sivachandra added inline comments.Jan 20 2022, 2:48 PM
libc/include/llvm-libc-types/tm.h
10

We need the prefix as we cannot pollute the namespace. But, the trailing underscores are just my personal choice. We can remove if there is a reason we should not have them.

The normal header guard rule does not apply here (and is not good enough because of namespace pollution) as these are part of the public headers and not internal libc headers.

This revision was landed with ongoing or failed builds.Jan 20 2022, 3:04 PM
This revision was automatically updated to reflect the committed changes.