This is an archive of the discontinued LLVM Phabricator instance.

Fix obvious typo
ClosedPublic

Authored by gftg on Jan 20 2022, 2:01 PM.

Details

Summary

The -fcf-protection option takes an optional argument, which allows the
requesting of control-flow protection on returns, or on indirect jumps
and calls, or both. One of the comments in the code applies to returns,
yet it mentions branches (for indirect calls and jumps). This patch
fixes this obvious typo.

Diff Detail

Event Timeline

gftg created this revision.Jan 20 2022, 2:01 PM
gftg added a comment.Jan 20 2022, 2:34 PM

/me wondering how to convert this draft submission into a regular one.

gftg updated this revision to Diff 401949.Jan 21 2022, 5:00 AM

Testing that using arc diff --edit --verbatim converts from draft to
regular diff.

gftg updated this revision to Diff 401963.Jan 21 2022, 5:39 AM
gftg edited the summary of this revision. (Show Details)

Update the commit message with something meaningful for the git history.

gftg published this revision for review.Jan 21 2022, 5:40 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 21 2022, 5:40 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
pengfei accepted this revision.Mar 6 2022, 4:05 AM

LGTM.

This revision is now accepted and ready to land.Mar 6 2022, 4:05 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 6 2022, 4:05 AM
Closed by commit rG862c3d4fbe18: Fix obvious typo (authored by gftg, committed by pengfei). · Explain WhyNov 29 2022, 10:01 PM
This revision was automatically updated to reflect the committed changes.