The floating point tricks used to get rounding mode require -frounding-math flag, which behaves differently on aarch64. Reverting back to use get_round instead.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Paths
| Differential D117824
[libc] Use get_round() instead of floating point tricks in generic hypot implementation. ClosedPublic Authored by lntue on Jan 20 2022, 11:45 AM.
Details Summary The floating point tricks used to get rounding mode require -frounding-math flag, which behaves differently on aarch64. Reverting back to use get_round instead.
Diff Detail
Event TimelineThis revision is now accepted and ready to land.Jan 20 2022, 11:50 AM This revision was landed with ongoing or failed builds.Jan 20 2022, 11:55 AM Closed by commit rGd4baf3b1322b: [libc] Use get_round() instead of floating point tricks in generic hypot… (authored by lntue). · Explain Why This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 401730 libc/src/__support/FPUtil/Hypot.h
libc/src/math/generic/CMakeLists.txt
|