This is an archive of the discontinued LLVM Phabricator instance.

Differential D117816

[flang] Fix OPEN/WRITE(SIGN='SUPPRESS')
ClosedPublic

Authored by klausler on Jan 20 2022, 11:07 AM.

Details

Reviewers
vdonaldson
Commits
rG5501c16edf0f: [flang] Fix OPEN/WRITE(SIGN='SUPPRESS')
Summary

The keyword value was misspelled in the runtime.

Diff Detail

Event Timeline

klausler created this revision.Jan 20 2022, 11:07 AM
Herald added a subscriber: jdoerfert. · View Herald TranscriptJan 20 2022, 11:07 AM
klausler requested review of this revision.Jan 20 2022, 11:07 AM
vdonaldson accepted this revision.Jan 20 2022, 11:09 AM
This revision is now accepted and ready to land.Jan 20 2022, 11:09 AM
Harbormaster completed remote builds in B144639: Diff 401710.Jan 20 2022, 1:04 PM
Closed by commit rG5501c16edf0f: [flang] Fix OPEN/WRITE(SIGN='SUPPRESS') (authored by klausler). · Explain WhyJan 20 2022, 3:34 PM
This revision was automatically updated to reflect the committed changes.
klausler added a commit: rG5501c16edf0f: [flang] Fix OPEN/WRITE(SIGN='SUPPRESS').
Herald added a project: Restricted Project. · View Herald TranscriptJan 20 2022, 3:34 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript

Revision Contents

PathSize
flang/
runtime/
3 lines

Diff 401710

flang/runtime/io-api.cpp

Context not available.
bool IONAME(SetSign)(Cookie cookie, const char *keyword, std::size_t length) { bool IONAME(SetSign)(Cookie cookie, const char *keyword, std::size_t length) {
IoStatementState &io{*cookie}; IoStatementState &io{*cookie};
ConnectionState &connection{io.GetConnectionState()}; ConnectionState &connection{io.GetConnectionState()};
static const char *keywords[]{"PLUS", "YES", "PROCESSOR_DEFINED", nullptr}; static const char *keywords[]{
"PLUS", "SUPPRESS", "PROCESSOR_DEFINED", nullptr};
switch (IdentifyValue(keyword, length, keywords)) { switch (IdentifyValue(keyword, length, keywords)) {
case 0: case 0:
connection.modes.editingFlags |= signPlus; connection.modes.editingFlags |= signPlus;
Context not available.