This is an archive of the discontinued LLVM Phabricator instance.

Differential D117813

[AMDGPU] Move const qualifier placement in AsmParser
AbandonedPublic

Authored by lamb-j on Jan 20 2022, 11:00 AM.

Details

Reviewers
None

Diff Detail

Event Timeline

lamb-j created this revision.Jan 20 2022, 11:00 AM
Herald added subscribers: foad, kerbowa, hiraditya and 8 others. · View Herald TranscriptJan 20 2022, 11:00 AM
lamb-j requested review of this revision.Jan 20 2022, 11:00 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 20 2022, 11:00 AM
Herald added subscribers: llvm-commits, wdng. · View Herald Transcript
lamb-j abandoned this revision.Jan 20 2022, 11:05 AM
Harbormaster completed remote builds in B144634: Diff 401705.Jan 20 2022, 12:35 PM

Revision Contents

PathSize
llvm/
lib/
Target/
AMDGPU/
AsmParser/
4 lines

Diff 401705

llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
//===- AMDGPUAsmParser.cpp - Parse SI asm to MCInst instructions ----------===// //===- AMDGPUAsmParser.cpp - Parse SI asm to MCInst instructions ----------===//
Lint: Lint
Inline Actions

clang-format not found in user’s local PATH; not linting file.

Lint: Lint: clang-format not found in user’s local PATH; not linting file.
// //
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information. // See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
▲ Show 20 Lines • Show All 1,115 Lines • ▼ Show 20 Linesclass KernelScopeInfo {
int SgprIndexUnusedMin = -1; int SgprIndexUnusedMin = -1;
int VgprIndexUnusedMin = -1; int VgprIndexUnusedMin = -1;
MCContext *Ctx = nullptr; MCContext *Ctx = nullptr;
void usesSgprAt(int i) { void usesSgprAt(int i) {
if (i >= SgprIndexUnusedMin) { if (i >= SgprIndexUnusedMin) {
SgprIndexUnusedMin = ++i; SgprIndexUnusedMin = ++i;
if (Ctx) { if (Ctx) {
MCSymbol * const Sym = Ctx->getOrCreateSymbol(Twine(".kernel.sgpr_count")); const MCSymbol *Sym = Ctx->getOrCreateSymbol(Twine(".kernel.sgpr_count"));
Lint: Pre-merge checks
Inline Actions

clang-format: please reformat the code

-        const MCSymbol *Sym = Ctx->getOrCreateSymbol(Twine(".kernel.sgpr_count"));
+        const MCSymbol *Sym =
+            Ctx->getOrCreateSymbol(Twine(".kernel.sgpr_count"));
Lint: Pre-merge checks: clang-format: please reformat the code ``` - const MCSymbol *Sym = Ctx…
Sym->setVariableValue(MCConstantExpr::create(SgprIndexUnusedMin, *Ctx)); Sym->setVariableValue(MCConstantExpr::create(SgprIndexUnusedMin, *Ctx));
} }
} }
} }
void usesVgprAt(int i) { void usesVgprAt(int i) {
if (i >= VgprIndexUnusedMin) { if (i >= VgprIndexUnusedMin) {
VgprIndexUnusedMin = ++i; VgprIndexUnusedMin = ++i;
if (Ctx) { if (Ctx) {
MCSymbol * const Sym = Ctx->getOrCreateSymbol(Twine(".kernel.vgpr_count")); const MCSymbol *Sym = Ctx->getOrCreateSymbol(Twine(".kernel.vgpr_count"));
Lint: Pre-merge checks
Inline Actions

clang-format: please reformat the code

-        const MCSymbol *Sym = Ctx->getOrCreateSymbol(Twine(".kernel.vgpr_count"));
+        const MCSymbol *Sym =
+            Ctx->getOrCreateSymbol(Twine(".kernel.vgpr_count"));
Lint: Pre-merge checks: clang-format: please reformat the code ``` - const MCSymbol *Sym = Ctx…
Sym->setVariableValue(MCConstantExpr::create(VgprIndexUnusedMin, *Ctx)); Sym->setVariableValue(MCConstantExpr::create(VgprIndexUnusedMin, *Ctx));
} }
} }
} }
public: public:
KernelScopeInfo() = default; KernelScopeInfo() = default;
▲ Show 20 Lines • Show All 7,228 Lines • Show Last 20 Lines