This is an archive of the discontinued LLVM Phabricator instance.

[DebugInfo][NFC] Do not call 'isRootFile' for DWARF Version < 5
ClosedPublic

Authored by ikudrin on Jan 20 2022, 7:17 AM.

Reviewers

Commits

Summary

A quicker comparison should be done first.

ikudrin requested review of this revision.Jan 20 2022, 7:17 AM

Sure, sounds reasonable

This revision is now accepted and ready to land.Jan 20 2022, 1:25 PM

This revision was landed with ongoing or failed builds.Jan 20 2022, 10:52 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

llvm/

lib/

MC/

2 lines

Show First 20 Lines • Show All 580 Lines • ▼ Show 20 Lines	MCDwarfLineTableHeader::tryGetFile(StringRef &Directory,
}		}
assert(!FileName.empty());		assert(!FileName.empty());
// Keep track of whether any or all files have an MD5 checksum.		// Keep track of whether any or all files have an MD5 checksum.
// If any files have embedded source, they all must.		// If any files have embedded source, they all must.
if (MCDwarfFiles.empty()) {		if (MCDwarfFiles.empty()) {
trackMD5Usage(Checksum.hasValue());		trackMD5Usage(Checksum.hasValue());
HasSource = (Source != None);		HasSource = (Source != None);
}		}
if (isRootFile(RootFile, Directory, FileName, Checksum) && DwarfVersion >= 5)		if (DwarfVersion >= 5 && isRootFile(RootFile, Directory, FileName, Checksum))
return 0;		return 0;
if (FileNumber == 0) {		if (FileNumber == 0) {
// File numbers start with 1 and/or after any file numbers		// File numbers start with 1 and/or after any file numbers
// allocated by inline-assembler .file directives.		// allocated by inline-assembler .file directives.
FileNumber = MCDwarfFiles.empty() ? 1 : MCDwarfFiles.size();		FileNumber = MCDwarfFiles.empty() ? 1 : MCDwarfFiles.size();
SmallString<256> Buffer;		SmallString<256> Buffer;
auto IterBool = SourceIdMap.insert(		auto IterBool = SourceIdMap.insert(
std::make_pair((Directory + Twine('\0') + FileName).toStringRef(Buffer),		std::make_pair((Directory + Twine('\0') + FileName).toStringRef(Buffer),
▲ Show 20 Lines • Show All 1,342 Lines • Show Last 20 Lines