This is an archive of the discontinued LLVM Phabricator instance.

[IRGen] Do not overwrite existing attributes in CGCall.
AbandonedPublicDraft

Authored by fhahn on Jan 20 2022, 4:59 AM.

Details

Reviewers
None
Summary

When adding new attributes, existing attributes are dropped. While
this appears to be a longstanding issue, this was highlighted by D105169
which dropped a lot of attributes due to adding the new noundef
attribute.

Ahmed Bougacha (@ab) tracked down the issue and provided the fix in
CGCall.cpp. I bundled it up and updated the tests.

Diff Detail

Event Timeline

fhahn created this revision.Jan 20 2022, 4:59 AM
fhahn updated this revision to Diff 401605.Jan 20 2022, 5:05 AM

Fix test

fhahn abandoned this revision.Jan 20 2022, 5:48 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 20 2022, 5:48 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript