This is an archive of the discontinued LLVM Phabricator instance.

Differential D117582

[libc++] Use reserved identifier for template parameter
ClosedPublic

Authored by abrachet on Jan 18 2022, 10:22 AM.

Details

Reviewers
ldionne
• Quuxplusone
Group Reviewers
Restricted Project
Commits
rG1dbe32dd9c3d: [libc++] Use reserved identifier for template parameter
Summary

T is not a valid identifier for libc++ to use, use _Tp instead. Caught from D116957

Diff Detail

Event Timeline

abrachet requested review of this revision.Jan 18 2022, 10:22 AM
abrachet created this revision.
• Quuxplusone accepted this revision.Jan 18 2022, 10:24 AM

Awesome! I guess this indicates that our buildkite CI never runs tests with _LIBCPP_ABI_OPTIMIZED_LOCALE_NUM_GET defined, is that right? :(

This revision is now accepted and ready to land.Jan 18 2022, 10:24 AM
• Quuxplusone mentioned this in D116957: [libc++] [test] Add a test for proper _Uglification of template parameter names.Jan 18 2022, 10:43 AM
This revision was landed with ongoing or failed builds.Jan 18 2022, 11:23 AM
Closed by commit rG1dbe32dd9c3d: [libc++] Use reserved identifier for template parameter (authored by abrachet). · Explain Why
This revision was automatically updated to reflect the committed changes.
abrachet added a commit: rG1dbe32dd9c3d: [libc++] Use reserved identifier for template parameter.
Herald added a project: Restricted Project. · View Herald TranscriptJan 18 2022, 11:23 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
Harbormaster completed remote builds in B144054: Diff 400902.Jan 18 2022, 12:01 PM
ldionne added a comment.Jan 20 2022, 4:00 PM
In D117582#3251829, @Quuxplusone wrote:

Awesome! I guess this indicates that our buildkite CI never runs tests with _LIBCPP_ABI_OPTIMIZED_LOCALE_NUM_GET defined, is that right? :(

We would probably need to run CI with the unstable ABI.

abrachet added a comment.Jan 20 2022, 4:05 PM

For reference, this was caught here

Revision Contents

PathSize
libcxx/
include/
6 lines

Diff 400923

libcxx/include/locale

Show First 20 Lines • Show All 410 Lines • ▼ Show 20 Lines const _CharT* __do_widen(ios_base& __iob, _CharT* __atoms) const
return __do_widen_p(__iob, __atoms); return __do_widen_p(__iob, __atoms);
} }
static int __stage2_int_loop(_CharT __ct, int __base, char* __a, char*& __a_end, static int __stage2_int_loop(_CharT __ct, int __base, char* __a, char*& __a_end,
unsigned& __dc, _CharT __thousands_sep, const string& __grouping, unsigned& __dc, _CharT __thousands_sep, const string& __grouping,
unsigned* __g, unsigned*& __g_end, const _CharT* __atoms); unsigned* __g, unsigned*& __g_end, const _CharT* __atoms);
private: private:
template<typename T> template<typename _Tp>
const T* __do_widen_p(ios_base& __iob, T* __atoms) const const _Tp* __do_widen_p(ios_base& __iob, _Tp* __atoms) const
{ {
locale __loc = __iob.getloc(); locale __loc = __iob.getloc();
use_facet<ctype<T> >(__loc).widen(__src, __src + 26, __atoms); use_facet<ctype<_Tp> >(__loc).widen(__src, __src + 26, __atoms);
return __atoms; return __atoms;
} }
const char* __do_widen_p(ios_base& __iob, char* __atoms) const const char* __do_widen_p(ios_base& __iob, char* __atoms) const
{ {
(void)__iob; (void)__iob;
(void)__atoms; (void)__atoms;
return __src; return __src;
▲ Show 20 Lines • Show All 3,911 Lines • Show Last 20 Lines