Page MenuHomePhabricator

[libc++] Use reserved identifier for template parameter
ClosedPublic

Authored by abrachet on Jan 18 2022, 10:22 AM.

Details

Summary

T is not a valid identifier for libc++ to use, use _Tp instead. Caught from D116957

Diff Detail

Event Timeline

abrachet requested review of this revision.Jan 18 2022, 10:22 AM
abrachet created this revision.
Quuxplusone accepted this revision.Jan 18 2022, 10:24 AM

Awesome! I guess this indicates that our buildkite CI never runs tests with _LIBCPP_ABI_OPTIMIZED_LOCALE_NUM_GET defined, is that right? :(

This revision is now accepted and ready to land.Jan 18 2022, 10:24 AM
This revision was landed with ongoing or failed builds.Jan 18 2022, 11:23 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJan 18 2022, 11:23 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript

Awesome! I guess this indicates that our buildkite CI never runs tests with _LIBCPP_ABI_OPTIMIZED_LOCALE_NUM_GET defined, is that right? :(

We would probably need to run CI with the unstable ABI.

For reference, this was caught here