Handle whitespace in symbol list

[beanz]

Summary

Trimming whitespace or carriage returns from symbols allows this code
to work on Windows and makes it match other places symbol lists are
handled.

No test provided because
test/Transforms/SampleProfile/uncompressed-profile-symbol-list.ll fails
on Windows if the git checkout uses CRLF line endings.

[MaskRay]

No test provided because test/Transforms/SampleProfile/uncompressed-profile-symbol-list.ll fails on Windows if the git checkout uses CRLF line endings.

You may just call SymbolStr.trim() (see `lld/Common/Args.cpp) and add a test with whitespace.

[beanz]

Upating based on feedback from @MaskRay!

[MaskRay]

LGTM.

llvm/test/Transforms/SampleProfile/Inputs/profile-symbol-list.text

10 ↗

(On Diff #400895)

You may add leading spaces to another line to make the intention clearer.

llvm/tools/llvm-profdata/llvm-profdata.cpp

665

The variable is only called once. Just inline SymbolStr.trim() into the caller.

[beanz]

More updates based on @MaskRay's feedback

llvm/tools/llvm-profdata/llvm-profdata.cpp

static void populateProfileSymbolList(MemoryBuffer *Buffer,
                                       sampleprof::ProfileSymbolList &PSL) {
   if (!Buffer)
     return;
 
   SmallVector<StringRef, 32> SymbolVec;
   StringRef Data = Buffer->getBuffer();
   Data.split(SymbolVec, '\n', /*MaxSplit=*/-1, /*KeepEmpty=*/false);
 
-  for (StringRef symbol : SymbolVec)
-    PSL.add(symbol);
+  for (StringRef SymbolStr : SymbolVec) {
+    StringRef SanitizedSymbol = SymbolStr.trim(" \t\v\f\r");
+    PSL.add(SanitizedSymbol);
+  }
 }
 
 static void handleExtBinaryWriter(sampleprof::SampleProfileWriter &Writer,
                                   ProfileFormat OutputFormat,
                                   MemoryBuffer *Buffer,
                                   sampleprof::ProfileSymbolList &WriterList,
                                   bool CompressAllSections, bool UseMD5,
                                   bool GenPartialProfile) {