This is an archive of the discontinued LLVM Phabricator instance.

In D117390#3246799, @kimgr wrote:

@daverec I don't have commit access, could you help me land this?

I've rebased on main without conflicts, and ninja check-clang ran successfully after rebase.

Let me know if there's anything else I can do as far as prep work.

@rsmith is the code owner, and would know best about prep, though he's not always available - Richard could you spare a glance and point @kimgr to any additional steps needed to land this and D117391?

@rsmith Weekly ping

@rsmith Gentle ping

The NFC changes LGTM! What name and email address would you like me to use for patch attribution?

@aaron.ballman Thanks! Please use Kim Gräsman and kim.grasman at gmail.com.

In D117390#3290715, @kimgr wrote:

@aaron.ballman Thanks! Please use Kim Gräsman and kim.grasman at gmail.com.

You're welcome. I've pushed on your behalf in d7ddad408f5b64df39a39f4af3a631275961b975. Thanks!

Revision Contents

Path

Size

clang/

unittests/

Tooling/

CastExprTest.cpp

34 lines

Diff 400264

clang/unittests/Tooling/CastExprTest.cpp

Show All 17 Lines	struct CastExprVisitor : TestVisitor<CastExprVisitor> {
bool VisitExplicitCastExpr(ExplicitCastExpr *Expr) {		bool VisitExplicitCastExpr(ExplicitCastExpr *Expr) {
if (OnExplicitCast)		if (OnExplicitCast)
OnExplicitCast(Expr);		OnExplicitCast(Expr);
return true;		return true;
}		}
};		};

TEST(CastExprTest, GetSubExprAsWrittenThroughMaterializedTemporary) {		TEST(CastExprTest, GetSubExprAsWrittenThroughMaterializedTemporary) {
CastExprVisitor Visitor;		CastExprVisitor Visitor;
Visitor.OnExplicitCast = [](ExplicitCastExpr *Expr) {		Visitor.OnExplicitCast = [](ExplicitCastExpr *Expr) {
auto Sub = Expr->getSubExprAsWritten();		auto Sub = Expr->getSubExprAsWritten();
EXPECT_TRUE(isa<DeclRefExpr>(Sub))		EXPECT_TRUE(isa<DeclRefExpr>(Sub))
<< "Expected DeclRefExpr, but saw " << Sub->getStmtClassName();		<< "Expected DeclRefExpr, but saw " << Sub->getStmtClassName();
};		};
Visitor.runOver("struct S1 {};\n"		Visitor.runOver("struct S1 {};\n"
"struct S2 { operator S1(); };\n"		"struct S2 { operator S1(); };\n"
"S1 f(S2 s) { return static_cast<S1>(s); }\n");		"S1 f(S2 s) { return static_cast<S1>(s); }\n");
}		}

// Verify that getSubExprAsWritten looks through a ConstantExpr in a scenario		// Verify that getSubExprAsWritten looks through a ConstantExpr in a scenario
// like		// like
//		//
// CXXFunctionalCastExpr functional cast to struct S <ConstructorConversion>		// CXXFunctionalCastExpr functional cast to struct S <ConstructorConversion>
// `-ConstantExpr 'S'		// `-ConstantExpr 'S'
// \|-value: Struct		// \|-value: Struct
// `-CXXConstructExpr 'S' 'void (int)'		// `-CXXConstructExpr 'S' 'void (int)'
// `-IntegerLiteral 'int' 0		// `-IntegerLiteral 'int' 0
TEST(CastExprTest, GetSubExprAsWrittenThroughConstantExpr) {		TEST(CastExprTest, GetSubExprAsWrittenThroughConstantExpr) {
CastExprVisitor Visitor;		CastExprVisitor Visitor;
Visitor.OnExplicitCast = [](ExplicitCastExpr *Expr) {		Visitor.OnExplicitCast = [](ExplicitCastExpr *Expr) {
auto *Sub = Expr->getSubExprAsWritten();		auto *Sub = Expr->getSubExprAsWritten();
EXPECT_TRUE(isa<IntegerLiteral>(Sub))		EXPECT_TRUE(isa<IntegerLiteral>(Sub))
<< "Expected IntegerLiteral, but saw " << Sub->getStmtClassName();		<< "Expected IntegerLiteral, but saw " << Sub->getStmtClassName();
};		};
Visitor.runOver("struct S { consteval S(int) {} };\n"		Visitor.runOver("struct S { consteval S(int) {} };\n"
"S f() { return S(0); }\n",		"S f() { return S(0); }\n",
CastExprVisitor::Lang_CXX2a);		CastExprVisitor::Lang_CXX2a);
}		}

}		} // namespace

This is an archive of the discontinued LLVM Phabricator instance.

[AST] Reformat CastExpr unittest suiteClosedPublic

Details

Diff Detail

Unit TestsFailed

Event Timeline

Revision Contents

Diff 400264

clang/unittests/Tooling/CastExprTest.cpp

[AST] Reformat CastExpr unittest suite
ClosedPublic