Page MenuHomePhabricator

davrec (David Rector)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 4 2021, 10:11 AM (19 w, 11 h)

Recent Activity

Sat, Jun 12

davrec accepted D104182: [clang][NFC] Add IsAnyDestructorNoReturn field to CXXRecord instead of calculating it on demand.
Sat, Jun 12, 6:17 PM · Restricted Project
davrec added a comment to D104182: [clang][NFC] Add IsAnyDestructorNoReturn field to CXXRecord instead of calculating it on demand.

Was this performance hit when using the static analyzer? A quick search suggests isAnyDestructorNoReturn() is only called within the analyzer, whereas comparable CXXRecordDecl methods whose results are stored (hasIrrelevantDestructor() etc.) seem to be called somewhere by Sema.

Sat, Jun 12, 12:24 PM · Restricted Project

Mon, May 24

davrec accepted D102241: [clang] p1099 4/5: using enum EnumTag.
Mon, May 24, 4:57 PM · Restricted Project, Restricted Project
davrec accepted D101777: [clang] p1099 1/5: [NFC] Break out BaseUsingDecl from UsingDecl.

Looks good, thanks for doing this!

Mon, May 24, 4:57 PM · Restricted Project, Restricted Project

Sat, May 22

davrec added inline comments to D102241: [clang] p1099 4/5: using enum EnumTag.
Sat, May 22, 12:46 PM · Restricted Project, Restricted Project
davrec added inline comments to D102241: [clang] p1099 4/5: using enum EnumTag.
Sat, May 22, 10:45 AM · Restricted Project, Restricted Project
davrec accepted D100276: [clang] p1099 3/5: using Enum::member.
Sat, May 22, 8:39 AM · Restricted Project
davrec accepted D102239: [clang][NFC] p1099 2/5: Break out enum completion from context completion.
Sat, May 22, 8:36 AM · Restricted Project
davrec accepted D101777: [clang] p1099 1/5: [NFC] Break out BaseUsingDecl from UsingDecl.

Sorry for the delay.
Richard should probably weigh in before absolutely committing to

  1. BaseUsingDecl/UsingEnumDecl/UsingDecl (as implemented here) vs. single UsingDecl (Nathan's original approach) and
  2. Renaming getUsingDecl() to getIntroducer() (if it is to return a BaseUsingDecl).
Sat, May 22, 8:26 AM · Restricted Project, Restricted Project
davrec accepted D102242: [clang] p1099 5/5: feature macro & web page.
Sat, May 22, 7:54 AM · Restricted Project

May 7 2021

davrec added inline comments to D101777: [clang] p1099 1/5: [NFC] Break out BaseUsingDecl from UsingDecl.
May 7 2021, 3:13 PM · Restricted Project, Restricted Project