This is an archive of the discontinued LLVM Phabricator instance.

[libcxx][test] Niebloids are not portably of `final` class type
AbandonedPublic

Authored by CaseyCarter on Jan 14 2022, 4:25 PM.

Details

Reviewers
cjdb
Quuxplusone
Group Reviewers
Restricted Project
Summary

... nor any of the other things tested by is_function_like, to be fair, but they pass with MSVC STL so :shrug:.

Diff Detail

Event Timeline

CaseyCarter requested review of this revision.Jan 14 2022, 4:25 PM
CaseyCarter created this revision.
Herald added 1 blocking reviewer(s): Restricted Project. · View Herald TranscriptJan 14 2022, 4:25 PM
Quuxplusone requested changes to this revision.Jan 15 2022, 6:48 AM

I believe this is obsolete since D116384: all uses of is_niebloid are now guarded under LIBCPP_STATIC_ASSERT at their call sites. E.g.

LIBCPP_STATIC_ASSERT(is_niebloid<decltype(std::ranges::prev)>());

That was the superior solution, because actually it's IFNDR even to try to compute decltype(std::ranges::prev) — overload sets don't have decltypes.
Recommend abandoning this.

See also D116570.

This revision now requires changes to proceed.Jan 15 2022, 6:48 AM
CaseyCarter abandoned this revision.Jan 15 2022, 1:05 PM

I believe this is obsolete since D116384: all uses of is_niebloid are now guarded under LIBCPP_STATIC_ASSERT at their call sites. E.g.

:facepalm:, I didn't notice D116384. Abandoning.