This is an archive of the discontinued LLVM Phabricator instance.

[scudo] Make Scudo compile for C++20
ClosedPublic

Authored by cryptoad on Jan 14 2022, 1:52 PM.

Details

Summary

In C++20 compound assignment to volatile (here LocalData[I]++) is
deprecated, so mutex_test.cpp fails to compile.

Simply changing it to LocalData[I] = LocalData[I] + 1 fixes it.

Diff Detail

Event Timeline

cryptoad requested review of this revision.Jan 14 2022, 1:52 PM
cryptoad created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptJan 14 2022, 1:52 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
schottm accepted this revision.Jan 14 2022, 1:54 PM
This revision is now accepted and ready to land.Jan 14 2022, 1:54 PM
hctim accepted this revision.Jan 14 2022, 2:08 PM
This revision now requires review to proceed.Jan 14 2022, 2:08 PM
hctim added a comment.Jan 14 2022, 2:09 PM

@ayermolo I think your rule (https://reviews.llvm.org/H844#2954) marks you as a blocking reviewer on every patchset.

hctim removed a reviewer: ayermolo.Jan 14 2022, 2:09 PM
This revision is now accepted and ready to land.Jan 14 2022, 2:09 PM
This revision now requires review to proceed.Jan 14 2022, 2:09 PM
hctim removed a reviewer: ayermolo.Jan 14 2022, 2:11 PM
This revision is now accepted and ready to land.Jan 14 2022, 2:11 PM
mcgrathr accepted this revision.Jan 14 2022, 2:27 PM
This revision was automatically updated to reflect the committed changes.