This is an archive of the discontinued LLVM Phabricator instance.

Differential D117338

[InstCombine] Add new tests that check the icmp-ashr baseline.
ClosedPublic

Authored by nadav on Jan 14 2022, 10:29 AM.

Details

Reviewers
spatel
craig.topper
Commits
rG8e47ccd5c26d: Add new tests that check the icmp-ashr baseline.
Summary

This commit adds new tests that check the patterns that D117252 will fix, as requested by @spatel.

Diff Detail

Event Timeline

nadav requested review of this revision.Jan 14 2022, 10:29 AM
nadav created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptJan 14 2022, 10:29 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
spatel accepted this revision.Jan 14 2022, 10:31 AM

LGTM

This revision is now accepted and ready to land.Jan 14 2022, 10:31 AM
nadav mentioned this in D117252: [InstCombine] Fold ashr-exact into a icmp-ugt. .Jan 14 2022, 10:31 AM
This revision was landed with ongoing or failed builds.Jan 14 2022, 10:59 AM
Closed by commit rG8e47ccd5c26d: Add new tests that check the icmp-ashr baseline. (authored by nadav). · Explain Why
This revision was automatically updated to reflect the committed changes.
nadav added a commit: rG8e47ccd5c26d: Add new tests that check the icmp-ashr baseline..
Harbormaster completed remote builds in B143446: Diff 400063.Jan 14 2022, 11:59 AM
nadav mentioned this in rG8dff860c220c: [NFC] Add additional tests for icmp predicate..Jan 14 2022, 3:27 PM

Revision Contents

PathSize
llvm/
test/
Transforms/
InstCombine/
117 lines

Diff 400063

llvm/test/Transforms/InstCombine/icmp-shr-lt-gt.ll

Context not available.
ret i1 %c ret i1 %c
} }
define i1 @ashr_00_00_noexact(i8 %x) {
; CHECK-LABEL: @ashr_00_00_noexact(
; CHECK-NEXT: [[C:%.*]] = icmp sgt i8 [[X:%.*]], 79
; CHECK-NEXT: ret i1 [[C]]
;
%s = ashr i8 %x, 3
%c = icmp sge i8 %s, 10
ret i1 %c
}
define i1 @ashr_00_01_noexact(i8 %x) {
; CHECK-LABEL: @ashr_00_01_noexact(
; CHECK-NEXT: [[C:%.*]] = icmp slt i8 [[X:%.*]], 80
; CHECK-NEXT: ret i1 [[C]]
;
%s = ashr i8 %x, 3
%c = icmp slt i8 %s, 10
ret i1 %c
}
define i1 @ashr_00_03_noexact(i8 %x) {
; CHECK-LABEL: @ashr_00_03_noexact(
; CHECK-NEXT: [[S:%.*]] = ashr i8 [[X:%.*]], 3
; CHECK-NEXT: [[C:%.*]] = icmp ult i8 [[S]], 10
; CHECK-NEXT: ret i1 [[C]]
;
%s = ashr i8 %x, 3
%c = icmp ult i8 %s, 10
ret i1 %c
}
define i1 @ashr_00_00_exact(i8 %x) {
; CHECK-LABEL: @ashr_00_00_exact(
; CHECK-NEXT: [[C:%.*]] = icmp ne i8 [[X:%.*]], 80
; CHECK-NEXT: ret i1 [[C]]
;
%s = ashr exact i8 %x, 3
%c = icmp ne i8 %s, 10
ret i1 %c
}
define i1 @ashr_00_01_exact(i8 %x) {
; CHECK-LABEL: @ashr_00_01_exact(
; CHECK-NEXT: [[C:%.*]] = icmp eq i8 [[X:%.*]], 80
; CHECK-NEXT: ret i1 [[C]]
;
%s = ashr exact i8 %x, 3
%c = icmp eq i8 %s, 10
ret i1 %c
}
define i1 @ashr_00_02_exact(i8 %x) {
; CHECK-LABEL: @ashr_00_02_exact(
; CHECK-NEXT: [[C:%.*]] = icmp sgt i8 [[X:%.*]], 80
; CHECK-NEXT: ret i1 [[C]]
;
%s = ashr exact i8 %x, 3
%c = icmp sgt i8 %s, 10
ret i1 %c
}
define i1 @ashr_00_03_exact(i8 %x) {
; CHECK-LABEL: @ashr_00_03_exact(
; CHECK-NEXT: [[C:%.*]] = icmp slt i8 [[X:%.*]], 88
; CHECK-NEXT: ret i1 [[C]]
;
%s = ashr exact i8 %x, 3
%c = icmp sle i8 %s, 10
ret i1 %c
}
define i1 @ashr_00_04_exact(i8 %x) {
; CHECK-LABEL: @ashr_00_04_exact(
; CHECK-NEXT: [[S:%.*]] = ashr exact i8 [[X:%.*]], 3
; CHECK-NEXT: [[C:%.*]] = icmp ugt i8 [[S]], 10
; CHECK-NEXT: ret i1 [[C]]
;
%s = ashr exact i8 %x, 3
%c = icmp ugt i8 %s, 10
ret i1 %c
}
define i1 @ashr_00_05_exact(i8 %x) {
; CHECK-LABEL: @ashr_00_05_exact(
; CHECK-NEXT: [[S:%.*]] = ashr exact i8 [[X:%.*]], 3
; CHECK-NEXT: [[C:%.*]] = icmp ult i8 [[S]], 11
; CHECK-NEXT: ret i1 [[C]]
;
%s = ashr exact i8 %x, 3
%c = icmp ule i8 %s, 10
ret i1 %c
}
define i1 @ashr_00_00_ashr_extra_use(i8 %x, i8* %ptr) {
; CHECK-LABEL: @ashr_00_00_ashr_extra_use(
; CHECK-NEXT: [[S:%.*]] = ashr exact i8 [[X:%.*]], 3
; CHECK-NEXT: [[C:%.*]] = icmp ult i8 [[S]], 11
; CHECK-NEXT: store i8 [[S]], i8* [[PTR:%.*]], align 1
; CHECK-NEXT: ret i1 [[C]]
;
%s = ashr exact i8 %x, 3
%c = icmp ule i8 %s, 10
store i8 %s, i8* %ptr
ret i1 %c
}
define <4 x i1> @ashr_00_00_vec(<4 x i8> %x) {
; CHECK-LABEL: @ashr_00_00_vec(
; CHECK-NEXT: [[S:%.*]] = ashr exact <4 x i8> [[X:%.*]], <i8 3, i8 3, i8 3, i8 3>
; CHECK-NEXT: [[C:%.*]] = icmp ult <4 x i8> [[S]], <i8 11, i8 11, i8 11, i8 11>
; CHECK-NEXT: ret <4 x i1> [[C]]
;
%s = ashr exact <4 x i8> %x, <i8 3,i8 3, i8 3, i8 3>
%c = icmp ule <4 x i8> %s, <i8 10,i8 10,i8 10,i8 10>
ret <4 x i1> %c
}
define i1 @lshrult_01_00_exact(i4 %x) { define i1 @lshrult_01_00_exact(i4 %x) {
; CHECK-LABEL: @lshrult_01_00_exact( ; CHECK-LABEL: @lshrult_01_00_exact(
; CHECK-NEXT: ret i1 false ; CHECK-NEXT: ret i1 false
Context not available.