This is an archive of the discontinued LLVM Phabricator instance.

[SelectionDAGBuilder] Remove unneeded vector bitcast from visitTargetIntrinsic.
ClosedPublic

Authored by craig.topper on Jan 14 2022, 10:01 AM.

Details

Summary

This seems to be a leftover from a long time ago when there was
an ISD::VBIT_CONVERT and a MVT::Vector. It looks like in those days
the vector type was carried in a VTSDNode.

As far as I know, these days ComputeValueTypes would have already
assigned "Result" the same type we're getting from TLI.getValueType
here. Thus the BITCAST is always a NOP. Verified by adding an assert
and running check-llvm.

Diff Detail

Event Timeline

craig.topper created this revision.Jan 14 2022, 10:01 AM
craig.topper requested review of this revision.Jan 14 2022, 10:01 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 14 2022, 10:01 AM
This revision is now accepted and ready to land.Jan 14 2022, 10:22 AM
This revision was landed with ongoing or failed builds.Jan 14 2022, 12:53 PM
This revision was automatically updated to reflect the committed changes.