This is an archive of the discontinued LLVM Phabricator instance.

Differential D117146

[libc] add working ARM entrypoints
ClosedPublic

Authored by michaelrj on Jan 12 2022, 1:47 PM.

Details

Reviewers
sivachandra
lntue
abrachet
Commits
rGba6a3972d74c: [libc] add working ARM entrypoints
Summary

Some functions were added to x86_64 that were untested on Aarch64. Now
that I've had an opportunity to test them, they all work on Aarch64 with
the minor formatting change included.

Diff Detail

Event Timeline

michaelrj created this revision.Jan 12 2022, 1:47 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 12 2022, 1:47 PM
Herald added subscribers: libc-commits, ecnelises, tschuett and 2 others. · View Herald Transcript
michaelrj requested review of this revision.Jan 12 2022, 1:47 PM
sivachandra accepted this revision.Jan 12 2022, 1:51 PM
This revision is now accepted and ready to land.Jan 12 2022, 1:51 PM
Harbormaster completed remote builds in B143001: Diff 399437.Jan 12 2022, 1:52 PM
Closed by commit rGba6a3972d74c: [libc] add working ARM entrypoints (authored by michaelrj). · Explain WhyJan 12 2022, 2:24 PM
This revision was automatically updated to reflect the committed changes.
michaelrj added a commit: rGba6a3972d74c: [libc] add working ARM entrypoints.

Revision Contents

PathSize
libc/
config/
linux/
aarch64/
13 lines
test/
src/
stdlib/
4 lines

Diff 399468

libc/config/linux/aarch64/entrypoints.txt

Show All 17 Linesset(TARGET_LIBC_ENTRYPOINTS
libc.src.ctype.toupper libc.src.ctype.toupper
# errno.h entrypoints # errno.h entrypoints
libc.src.errno.__errno_location libc.src.errno.__errno_location
# string.h entrypoints # string.h entrypoints
libc.src.string.bcmp libc.src.string.bcmp
libc.src.string.bzero libc.src.string.bzero
libc.src.string.memccpy
libc.src.string.memchr libc.src.string.memchr
libc.src.string.memcmp libc.src.string.memcmp
libc.src.string.memcpy libc.src.string.memcpy
libc.src.string.memmove libc.src.string.memmove
libc.src.string.memset libc.src.string.mempcpy
libc.src.string.memrchr libc.src.string.memrchr
libc.src.string.memset
libc.src.string.stpcpy
libc.src.string.stpncpy
libc.src.string.strcat libc.src.string.strcat
libc.src.string.strchr libc.src.string.strchr
libc.src.string.strcpy
libc.src.string.strcmp libc.src.string.strcmp
libc.src.string.strcpy
libc.src.string.strcspn libc.src.string.strcspn
libc.src.string.strlen libc.src.string.strlen
libc.src.string.strncat
libc.src.string.strncmp libc.src.string.strncmp
libc.src.string.strncpy libc.src.string.strncpy
libc.src.string.strnlen libc.src.string.strnlen
libc.src.string.strpbrk libc.src.string.strpbrk
libc.src.string.strrchr libc.src.string.strrchr
libc.src.string.strspn libc.src.string.strspn
libc.src.string.strstr libc.src.string.strstr
libc.src.string.strtok libc.src.string.strtok
libc.src.string.strtok_r libc.src.string.strtok_r
# inttypes.h entrypoints # inttypes.h entrypoints
libc.src.inttypes.imaxdiv libc.src.inttypes.imaxdiv
libc.src.inttypes.strtoimax libc.src.inttypes.strtoimax
libc.src.inttypes.strtoumax libc.src.inttypes.strtoumax
# stdlib.h entrypoints # stdlib.h entrypoints
libc.src.stdlib.abs libc.src.stdlib.abs
libc.src.stdlib.atoi libc.src.stdlib.atoi
libc.src.stdlib.atof
libc.src.stdlib.atol libc.src.stdlib.atol
libc.src.stdlib.atoll libc.src.stdlib.atoll
libc.src.stdlib.bsearch libc.src.stdlib.bsearch
libc.src.stdlib.div libc.src.stdlib.div
libc.src.stdlib.labs libc.src.stdlib.labs
libc.src.stdlib.ldiv libc.src.stdlib.ldiv
libc.src.stdlib.llabs libc.src.stdlib.llabs
libc.src.stdlib.lldiv libc.src.stdlib.lldiv
libc.src.stdlib.qsort libc.src.stdlib.qsort
libc.src.stdlib.strtod
libc.src.stdlib.strtof
libc.src.stdlib.strtol libc.src.stdlib.strtol
libc.src.stdlib.strtold
libc.src.stdlib.strtoll libc.src.stdlib.strtoll
libc.src.stdlib.strtoul libc.src.stdlib.strtoul
libc.src.stdlib.strtoull libc.src.stdlib.strtoull
) )
set(TARGET_LIBM_ENTRYPOINTS set(TARGET_LIBM_ENTRYPOINTS
# fenv.h entrypoints # fenv.h entrypoints
libc.src.fenv.feclearexcept libc.src.fenv.feclearexcept
▲ Show 20 Lines • Show All 108 Lines • Show Last 20 Lines

libc/test/src/stdlib/strtold_test.cpp

Show First 20 Lines • Show All 58 Lines • ▼ Show 20 Lines void run_test(const char *inputString, const ptrdiff_t expectedStrLen,
// SEEEEEEEEEEEEEEEMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMM...M // SEEEEEEEEEEEEEEEMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMM...M
// | | // | |
// +------+------+ // +------+------+
// | // |
// +-- 15 Exponent Bits // +-- 15 Exponent Bits
char *str_end = nullptr; char *str_end = nullptr;
#if defined(LONG_DOUBLE_IS_DOUBLE) #if defined(LONG_DOUBLE_IS_DOUBLE)
__llvm_libc::fputil::FPBits<long double> expectedFP = __llvm_libc::fputil::FPBits<long double> expected_fp =
__llvm_libc::fputil::FPBits<long double>(expectedRawData64); __llvm_libc::fputil::FPBits<long double>(expectedRawData64);
const int expectedErrno = expectedErrno64; const int expectedErrno = expectedErrno64;
#elif defined(SPECIAL_X86_LONG_DOUBLE) #elif defined(SPECIAL_X86_LONG_DOUBLE)
__llvm_libc::fputil::FPBits<long double> expected_fp = __llvm_libc::fputil::FPBits<long double> expected_fp =
__llvm_libc::fputil::FPBits<long double>(expectedRawData80); __llvm_libc::fputil::FPBits<long double>(expectedRawData80);
const int expected_errno = expectedErrno80; const int expected_errno = expectedErrno80;
#else #else
__llvm_libc::fputil::FPBits<long double> expectedFP = __llvm_libc::fputil::FPBits<long double> expected_fp =
__llvm_libc::fputil::FPBits<long double>(expectedRawData128); __llvm_libc::fputil::FPBits<long double>(expectedRawData128);
const int expectedErrno = expectedErrno128; const int expectedErrno = expectedErrno128;
#endif #endif
errno = 0; errno = 0;
long double result = __llvm_libc::strtold(inputString, &str_end); long double result = __llvm_libc::strtold(inputString, &str_end);
__llvm_libc::fputil::FPBits<long double> actual_fp = __llvm_libc::fputil::FPBits<long double> actual_fp =
▲ Show 20 Lines • Show All 140 Lines • Show Last 20 Lines