This is an archive of the discontinued LLVM Phabricator instance.

[NFC] Minimize noundef analysis when disabled
ClosedPublic

Authored by kda on Jan 11 2022, 7:17 PM.

Details

Summary

Minor adjustment in order of noundef analysis to be a bit more optimal (when disabled).

Diff Detail

Event Timeline

kda requested review of this revision.Jan 11 2022, 7:17 PM
kda created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptJan 11 2022, 7:18 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
vitalybuka accepted this revision.Jan 12 2022, 1:07 PM

my editor recommends me to keep git titles <50 chars
Maybe something shorter with exactly the same meaning
"[NFC] Optimize noundef analysis condition"

clang/lib/CodeGen/CGCall.cpp
2382–2384
This revision is now accepted and ready to land.Jan 12 2022, 1:07 PM
kda edited the summary of this revision. (Show Details)Jan 12 2022, 1:24 PM
kda retitled this revision from Minor adjustment in order of noundef analysis to be a bit more optimal (when disabled). to [NFC] Minimize noundef analysis when disabled.
kda updated this revision to Diff 399432.Jan 12 2022, 1:32 PM
kda marked an inline comment as done.

reduce nesting

kda added a comment.Jan 12 2022, 1:32 PM

my editor recommends me to keep git titles <50 chars
Maybe something shorter with exactly the same meaning
"[NFC] Optimize noundef analysis condition"

Done!

This revision was landed with ongoing or failed builds.Jan 12 2022, 5:21 PM
This revision was automatically updated to reflect the committed changes.