Page MenuHomePhabricator

[Demangle] Pass Ret parameter from decodeNumber by reference
ClosedPublic

Authored by ljmf00 on Jan 11 2022, 12:18 PM.

Details

Summary

Since Ret parameter is never meant to be nullptr, let's pass it by reference instead of a raw pointer.

Diff Detail

Unit TestsFailed

TimeTest
2,060 msx64 debian > libFuzzer.libFuzzer::fuzzer-finalstats.test
Script: -- : 'RUN: at line 1'; /var/lib/buildkite-agent/builds/llvm-project/build/./bin/clang --driver-mode=g++ -O2 -gline-tables-only -fsanitize=address,fuzzer -I/var/lib/buildkite-agent/builds/llvm-project/compiler-rt/lib/fuzzer -m64 /var/lib/buildkite-agent/builds/llvm-project/compiler-rt/test/fuzzer/SimpleTest.cpp -o /var/lib/buildkite-agent/builds/llvm-project/build/projects/compiler-rt/test/fuzzer/X86_64DefaultLinuxConfig/Output/fuzzer-finalstats.test.tmp-SimpleTest

Event Timeline

ljmf00 created this revision.Jan 11 2022, 12:18 PM
ljmf00 requested review of this revision.Jan 11 2022, 12:18 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 11 2022, 12:18 PM
dblaikie accepted this revision.Jan 11 2022, 5:59 PM

Great, thanks!

This revision is now accepted and ready to land.Jan 11 2022, 5:59 PM
ljmf00 updated this revision to Diff 399184.Jan 11 2022, 7:29 PM
This revision was landed with ongoing or failed builds.Jan 12 2022, 2:02 PM
This revision was automatically updated to reflect the committed changes.