This is an archive of the discontinued LLVM Phabricator instance.

Differential D116916

[lld-macho][test] Add missing coverage for archive/dylib resolution after D115092
ClosedPublic

Authored by MaskRay on Jan 9 2022, 10:02 PM.

Details

Reviewers
int3
oontvoo
Group Reviewers
Restricted Project
Commits
rG2968467e3990: [lld-macho][test] Add missing coverage for archive/dylib resolution after…
Summary

When file->fetch(sym) is replaced with a no-op, no test fails.

The new test catches the case.

Diff Detail

Event Timeline

MaskRay created this revision.Jan 9 2022, 10:02 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 9 2022, 10:02 PM
MaskRay requested review of this revision.Jan 9 2022, 10:02 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 9 2022, 10:02 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
MaskRay mentioned this in D115092: [lld-macho] Unreferenced weak dylib symbols shouldn't fetch archive symbols.Jan 9 2022, 10:19 PM
Harbormaster completed remote builds in B142357: Diff 398510.Jan 9 2022, 10:22 PM
oontvoo accepted this revision.Jan 10 2022, 7:10 AM

LG - thanks!

This revision is now accepted and ready to land.Jan 10 2022, 7:10 AM
Closed by commit rG2968467e3990: [lld-macho][test] Add missing coverage for archive/dylib resolution after… (authored by MaskRay). · Explain WhyJan 10 2022, 7:36 PM
This revision was automatically updated to reflect the committed changes.
MaskRay added a commit: rG2968467e3990: [lld-macho][test] Add missing coverage for archive/dylib resolution after….

Revision Contents

PathSize
lld/
test/
MachO/
2 lines

Diff 398510

lld/test/MachO/weak-definition-direct-fetch.s

Show First 20 Lines • Show All 95 Lines • ▼ Show 20 Lines
# RUN: %lld -dylib -lSystem -o %t/weak-unref-dylib-weak-ar -L%t -lweakfoo %t/weakfoo.a # RUN: %lld -dylib -lSystem -o %t/weak-unref-dylib-weak-ar -L%t -lweakfoo %t/weakfoo.a
# RUN: llvm-objdump --macho --lazy-bind --syms %t/weak-unref-dylib-weak-ar | FileCheck %s --check-prefix=NO-SYM # RUN: llvm-objdump --macho --lazy-bind --syms %t/weak-unref-dylib-weak-ar | FileCheck %s --check-prefix=NO-SYM
## However, weak references are sufficient to cause the archive to be loaded. ## However, weak references are sufficient to cause the archive to be loaded.
# RUN: %lld -dylib -lSystem -o %t/weak-ar-weak-ref-weak-dylib -L%t %t/weakfoo.a -lweakfoo %t/weak-refs-foo.o # RUN: %lld -dylib -lSystem -o %t/weak-ar-weak-ref-weak-dylib -L%t %t/weakfoo.a -lweakfoo %t/weak-refs-foo.o
# RUN: llvm-objdump --macho --lazy-bind --syms %t/weak-ar-weak-ref-weak-dylib | FileCheck %s --check-prefix=PREFER-WEAK-OBJECT # RUN: llvm-objdump --macho --lazy-bind --syms %t/weak-ar-weak-ref-weak-dylib | FileCheck %s --check-prefix=PREFER-WEAK-OBJECT
# RUN: %lld -dylib -lSystem -o %t/weak-ref-weak-dylib-weak-ar -L%t -lweakfoo %t/weakfoo.a %t/weak-refs-foo.o # RUN: %lld -dylib -lSystem -o %t/weak-ref-weak-dylib-weak-ar -L%t -lweakfoo %t/weakfoo.a %t/weak-refs-foo.o
# RUN: llvm-objdump --macho --lazy-bind --syms %t/weak-ref-weak-dylib-weak-ar | FileCheck %s --check-prefix=PREFER-WEAK-OBJECT # RUN: llvm-objdump --macho --lazy-bind --syms %t/weak-ref-weak-dylib-weak-ar | FileCheck %s --check-prefix=PREFER-WEAK-OBJECT
# RUN: %lld -dylib -lSystem -o %t/weak-ref-weak-dylib-weak-ar -L%t -lweakfoo %t/weak-refs-foo.o %t/weakfoo.a
# RUN: llvm-objdump --macho --lazy-bind --syms %t/weak-ref-weak-dylib-weak-ar | FileCheck %s --check-prefix=PREFER-WEAK-OBJECT
#--- foo.s #--- foo.s
.globl _foo .globl _foo
.section __TEXT,nonweak .section __TEXT,nonweak
_foo: _foo:
#--- weakfoo.s #--- weakfoo.s
.globl _foo .globl _foo
Show All 16 Lines