This is an archive of the discontinued LLVM Phabricator instance.

Differential D116912

[lldb] Check for arm64 in TestDisassembleRawData
ClosedPublic

Authored by kastiglione on Jan 9 2022, 8:14 PM.

Details

Reviewers
jasonmolenda
JDevlieghere
Commits
rGaad27a890754: [lldb] Check for arm64 in TestDisassembleRawData
Summary

This test checks for aarch64 but the lit config could also contain arm64.
This change adds arm64 to make the test pass in all cases.

Diff Detail

Event Timeline

kastiglione created this revision.Jan 9 2022, 8:14 PM
Herald added subscribers: omjavaid, kristof.beyls. · View Herald TranscriptJan 9 2022, 8:14 PM
kastiglione requested review of this revision.Jan 9 2022, 8:14 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 9 2022, 8:14 PM
Herald added a subscriber: lldb-commits. · View Herald Transcript
Harbormaster completed remote builds in B142348: Diff 398492.Jan 9 2022, 8:16 PM
JDevlieghere accepted this revision.Jan 9 2022, 9:16 PM

LGTM

This revision is now accepted and ready to land.Jan 9 2022, 9:16 PM
Closed by commit rGaad27a890754: [lldb] Check for arm64 in TestDisassembleRawData (authored by kastiglione). · Explain WhyJan 9 2022, 9:37 PM
This revision was automatically updated to reflect the committed changes.
kastiglione added a commit: rGaad27a890754: [lldb] Check for arm64 in TestDisassembleRawData.

Revision Contents

PathSize
lldb/
test/
API/
python_api/
disassemble-raw-data/
4 lines

Diff 398506

lldb/test/API/python_api/disassemble-raw-data/TestDisassembleRawData.py

Show All 25 Lines def test_disassemble_raw_data(self):
target = self.dbg.CreateTargetWithFileAndTargetTriple("", "mipsel") target = self.dbg.CreateTargetWithFileAndTargetTriple("", "mipsel")
raw_bytes = bytearray([0x21, 0xf0, 0xa0, 0x03]) raw_bytes = bytearray([0x21, 0xf0, 0xa0, 0x03])
elif re.match("mips", arch): elif re.match("mips", arch):
target = self.dbg.CreateTargetWithFileAndTargetTriple("", "mips") target = self.dbg.CreateTargetWithFileAndTargetTriple("", "mips")
raw_bytes = bytearray([0x03, 0xa0, 0xf0, 0x21]) raw_bytes = bytearray([0x03, 0xa0, 0xf0, 0x21])
elif re.match("powerpc64le", arch): elif re.match("powerpc64le", arch):
target = self.dbg.CreateTargetWithFileAndTargetTriple("", "powerpc64le") target = self.dbg.CreateTargetWithFileAndTargetTriple("", "powerpc64le")
raw_bytes = bytearray([0x00, 0x00, 0x80, 0x38]) raw_bytes = bytearray([0x00, 0x00, 0x80, 0x38])
elif arch == "aarch64": elif arch in ("aarch64", "arm64"):
target = self.dbg.CreateTargetWithFileAndTargetTriple("", "aarch64") target = self.dbg.CreateTargetWithFileAndTargetTriple("", "aarch64")
raw_bytes = bytearray([0x60, 0x0c, 0x80, 0x52]) raw_bytes = bytearray([0x60, 0x0c, 0x80, 0x52])
elif arch == "arm": elif arch == "arm":
target = self.dbg.CreateTargetWithFileAndTargetTriple("", "arm") target = self.dbg.CreateTargetWithFileAndTargetTriple("", "arm")
raw_bytes = bytearray([0x63, 0x30, 0xa0, 0xe3]) raw_bytes = bytearray([0x63, 0x30, 0xa0, 0xe3])
else: else:
target = self.dbg.CreateTargetWithFileAndTargetTriple("", "x86_64") target = self.dbg.CreateTargetWithFileAndTargetTriple("", "x86_64")
raw_bytes = bytearray([0x48, 0x89, 0xe5]) raw_bytes = bytearray([0x48, 0x89, 0xe5])
Show All 9 Lines def test_disassemble_raw_data(self):
print("Disassembled%s" % str(inst)) print("Disassembled%s" % str(inst))
if re.match("mips", arch): if re.match("mips", arch):
self.assertEqual(inst.GetMnemonic(target), "move") self.assertEqual(inst.GetMnemonic(target), "move")
self.assertEqual(inst.GetOperands(target), self.assertEqual(inst.GetOperands(target),
'$' + "fp, " + '$' + "sp") '$' + "fp, " + '$' + "sp")
elif re.match("powerpc64le", arch): elif re.match("powerpc64le", arch):
self.assertEqual(inst.GetMnemonic(target), "li") self.assertEqual(inst.GetMnemonic(target), "li")
self.assertEqual(inst.GetOperands(target), "4, 0") self.assertEqual(inst.GetOperands(target), "4, 0")
elif arch == "aarch64": elif arch in ("aarch64", "arm64"):
self.assertEqual(inst.GetMnemonic(target), "mov") self.assertEqual(inst.GetMnemonic(target), "mov")
self.assertEqual(inst.GetOperands(target), "w0, #0x63") self.assertEqual(inst.GetOperands(target), "w0, #0x63")
elif arch == "arm": elif arch == "arm":
self.assertEqual(inst.GetMnemonic(target), "mov") self.assertEqual(inst.GetMnemonic(target), "mov")
self.assertEqual(inst.GetOperands(target), "r3, #99") self.assertEqual(inst.GetOperands(target), "r3, #99")
else: else:
self.assertEqual(inst.GetMnemonic(target), "movq") self.assertEqual(inst.GetMnemonic(target), "movq")
self.assertEqual(inst.GetOperands(target), self.assertEqual(inst.GetOperands(target),
'%' + "rsp, " + '%' + "rbp") '%' + "rsp, " + '%' + "rbp")