This is an archive of the discontinued LLVM Phabricator instance.

Differential D116837

Fix GDB printers test
ClosedPublic

Authored by csigg on Jan 7 2022, 1:46 PM.

Details

Reviewers
None
Commits
rGfb4869e26c80: Fix GDB printers test
Summary
  • Prevent symbols from being stripped so that it can run with 'RelWithDebInfo'.
  • Adjust llvm-support CHECKs after code changes.
  • Polish mlir-support CHECKs as suggested in https://reviews.llvm.org/D116646.

Diff Detail

Event Timeline

csigg created this revision.Jan 7 2022, 1:46 PM
Herald added subscribers: sdasgup3, wenzhicui, wrengr and 21 others. · View Herald TranscriptJan 7 2022, 1:46 PM
csigg requested review of this revision.Jan 7 2022, 1:46 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 7 2022, 1:46 PM
Herald added subscribers: llvm-commits, stephenneuendorffer, nicolasvasilache. · View Herald Transcript
Harbormaster completed remote builds in B142149: Diff 398229.Jan 7 2022, 1:50 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jan 7 2022, 11:36 PM
Closed by commit rGfb4869e26c80: Fix GDB printers test (authored by csigg). · Explain Why
This revision was automatically updated to reflect the committed changes.
csigg added a commit: rGfb4869e26c80: Fix GDB printers test.

Revision Contents

PathSize
cross-project-tests/
debuginfo-tests/
llvm-prettyprinters/
gdb/
19 lines
8 lines
10 lines
91 lines

Diff 398315

cross-project-tests/debuginfo-tests/llvm-prettyprinters/gdb/llvm-support.cpp

Show First 20 Lines • Show All 55 Lines • ▼ Show 20 Lines
auto SimpleIlist = []() { auto SimpleIlist = []() {
llvm::simple_ilist<IlistNode, SimpleIlistTag> Result; llvm::simple_ilist<IlistNode, SimpleIlistTag> Result;
for (auto &Node : Ilist) for (auto &Node : Ilist)
Result.push_front(Node); Result.push_front(Node);
return Result; return Result;
}(); }();
int main() { int main() {
// Reference symbols that might otherwise be stripped. std::uintptr_t result = 0;
ArrayRef[0]; auto dont_strip = [&](const auto &val) {
MutableArrayRef[0]; result += reinterpret_cast<std::uintptr_t>(&val);
(void)!ExpectedValue; };
(void)!ExpectedError; dont_strip(ArrayRef);
*OptionalValue; dont_strip(MutableArrayRef);
*OptionalNone; dont_strip(ExpectedValue);
return 0; dont_strip(ExpectedError);
dont_strip(OptionalValue);
dont_strip(OptionalNone);
return result; // Non-zero return value is OK.
} }

cross-project-tests/debuginfo-tests/llvm-prettyprinters/gdb/llvm-support.gdb

Show First 20 Lines • Show All 58 Lines • ▼ Show 20 Lines
# CHECK: { # CHECK: {
# CHECK: [0] = { # CHECK: [0] = {
# CHECK: <llvm::ilist_node<IlistNode, llvm::ilist_tag<A> >> = { # CHECK: <llvm::ilist_node<IlistNode, llvm::ilist_tag<A> >> = {
# CHECK: prev = [[Ilist_Sentinel:0x.*]] <Ilist>, # CHECK: prev = [[Ilist_Sentinel:0x.*]] <Ilist>,
# CHECK: next = [[Node_14:0x.*]] # CHECK: next = [[Node_14:0x.*]]
# CHECK: }, # CHECK: },
# CHECK: <llvm::ilist_node<IlistNode, llvm::ilist_tag<B> >> = { # CHECK: <llvm::ilist_node<IlistNode, llvm::ilist_tag<B> >> = {
# CHECK: prev = [[Node_14]], # CHECK: prev = [[Node_14]],
# CHECK: next = [[SimpleIlist_Sentinel:0x.*]] <SimpleIlist> # CHECK: next = [[SimpleIlist_Sentinel:0x.*]] <completed>
# CHECK: }, # CHECK: },
# CHECK: members of IlistNode: # CHECK: members of IlistNode:
# CHECK: Value = 13 # CHECK: Value = 13
# CHECK: }, # CHECK: },
# CHECK: [1] = { # CHECK: [1] = {
# CHECK: <llvm::ilist_node<IlistNode, llvm::ilist_tag<A> >> = { # CHECK: <llvm::ilist_node<IlistNode, llvm::ilist_tag<A> >> = {
# CHECK: prev = [[Node_13:0x.*]], # CHECK: prev = [[Node_13:0x.*]],
# CHECK: next = [[Node_15:0x.*]] # CHECK: next = [[Node_15:0x.*]]
# CHECK: }, # CHECK: },
# CHECK: <llvm::ilist_node<IlistNode, llvm::ilist_tag<B> >> = { # CHECK: <llvm::ilist_node<IlistNode, llvm::ilist_tag<B> >> = {
# CHECK: prev = [[Node_15]], # CHECK: prev = [[Node_15]],
# CHECK: next = [[Node_13]] # CHECK: next = [[Node_13]]
# CHECK: }, # CHECK: },
# CHECK: members of IlistNode: # CHECK: members of IlistNode:
# CHECK: Value = 14 # CHECK: Value = 14
# CHECK: }, # CHECK: },
# CHECK: [2] = { # CHECK: [2] = {
# CHECK: <llvm::ilist_node<IlistNode, llvm::ilist_tag<A> >> = { # CHECK: <llvm::ilist_node<IlistNode, llvm::ilist_tag<A> >> = {
# CHECK: prev = [[Node_14]], # CHECK: prev = [[Node_14]],
# CHECK: next = [[Ilist_Sentinel]] <Ilist> # CHECK: next = [[Ilist_Sentinel]] <Ilist>
# CHECK: }, # CHECK: },
# CHECK: <llvm::ilist_node<IlistNode, llvm::ilist_tag<B> >> = { # CHECK: <llvm::ilist_node<IlistNode, llvm::ilist_tag<B> >> = {
# CHECK: prev = [[SimpleIlist_Sentinel]] <SimpleIlist>, # CHECK: prev = [[SimpleIlist_Sentinel]] <completed>,
# CHECK: next = [[Node_14]] # CHECK: next = [[Node_14]]
# CHECK: }, # CHECK: },
# CHECK: members of IlistNode: # CHECK: members of IlistNode:
# CHECK: Value = 15 # CHECK: Value = 15
# CHECK: } # CHECK: }
# CHECK: } # CHECK: }
p Ilist p Ilist
# CHECK: { # CHECK: {
# CHECK: [0] = { # CHECK: [0] = {
# CHECK: <llvm::ilist_node<IlistNode, llvm::ilist_tag<A> >> = { # CHECK: <llvm::ilist_node<IlistNode, llvm::ilist_tag<A> >> = {
# CHECK: prev = [[Node_14]], # CHECK: prev = [[Node_14]],
# CHECK: next = [[Ilist_Sentinel]] <Ilist> # CHECK: next = [[Ilist_Sentinel]] <Ilist>
# CHECK: }, # CHECK: },
# CHECK: <llvm::ilist_node<IlistNode, llvm::ilist_tag<B> >> = { # CHECK: <llvm::ilist_node<IlistNode, llvm::ilist_tag<B> >> = {
# CHECK: prev = [[SimpleIlist_Sentinel]] <SimpleIlist>, # CHECK: prev = [[SimpleIlist_Sentinel]] <completed>,
# CHECK: next = [[Node_14]] # CHECK: next = [[Node_14]]
# CHECK: }, # CHECK: },
# CHECK: members of IlistNode: # CHECK: members of IlistNode:
# CHECK: Value = 15 # CHECK: Value = 15
# CHECK: }, # CHECK: },
# CHECK: [1] = { # CHECK: [1] = {
# CHECK: <llvm::ilist_node<IlistNode, llvm::ilist_tag<A> >> = { # CHECK: <llvm::ilist_node<IlistNode, llvm::ilist_tag<A> >> = {
# CHECK: prev = [[Node_13]], # CHECK: prev = [[Node_13]],
# CHECK: next = [[Node_15]] # CHECK: next = [[Node_15]]
# CHECK: }, # CHECK: },
# CHECK: <llvm::ilist_node<IlistNode, llvm::ilist_tag<B> >> = { # CHECK: <llvm::ilist_node<IlistNode, llvm::ilist_tag<B> >> = {
# CHECK: prev = [[Node_15]], # CHECK: prev = [[Node_15]],
# CHECK: next = [[Node_13]] # CHECK: next = [[Node_13]]
# CHECK: }, # CHECK: },
# CHECK: members of IlistNode: # CHECK: members of IlistNode:
# CHECK: Value = 14 # CHECK: Value = 14
# CHECK: }, # CHECK: },
# CHECK: [2] = { # CHECK: [2] = {
# CHECK: <llvm::ilist_node<IlistNode, llvm::ilist_tag<A> >> = { # CHECK: <llvm::ilist_node<IlistNode, llvm::ilist_tag<A> >> = {
# CHECK: prev = [[Ilist_Sentinel]] <Ilist>, # CHECK: prev = [[Ilist_Sentinel]] <Ilist>,
# CHECK: next = [[Node_14]] # CHECK: next = [[Node_14]]
# CHECK: }, # CHECK: },
# CHECK: <llvm::ilist_node<IlistNode, llvm::ilist_tag<B> >> = { # CHECK: <llvm::ilist_node<IlistNode, llvm::ilist_tag<B> >> = {
# CHECK: prev = [[Node_14]], # CHECK: prev = [[Node_14]],
# CHECK: next = [[SimpleIlist_Sentinel]] <SimpleIlist> # CHECK: next = [[SimpleIlist_Sentinel]] <completed>
# CHECK: }, # CHECK: },
# CHECK: members of IlistNode: # CHECK: members of IlistNode:
# CHECK: Value = 13 # CHECK: Value = 13
# CHECK: } # CHECK: }
# CHECK: } # CHECK: }
p SimpleIlist p SimpleIlist

cross-project-tests/debuginfo-tests/llvm-prettyprinters/gdb/mlir-support.cpp

Show All 35 Lines
mlir::Attribute FloatAttr = mlir::FloatAttr::get(FloatType, 1.0); mlir::Attribute FloatAttr = mlir::FloatAttr::get(FloatType, 1.0);
mlir::Attribute IntegerAttr = mlir::IntegerAttr::get(IntegerType, 10); mlir::Attribute IntegerAttr = mlir::IntegerAttr::get(IntegerType, 10);
mlir::Attribute TypeAttr = mlir::TypeAttr::get(IndexType); mlir::Attribute TypeAttr = mlir::TypeAttr::get(IndexType);
mlir::Attribute ArrayAttr = mlir::ArrayAttr::get(&Context, {UnitAttr}); mlir::Attribute ArrayAttr = mlir::ArrayAttr::get(&Context, {UnitAttr});
mlir::Attribute StringAttr = mlir::StringAttr::get(&Context, "foo"); mlir::Attribute StringAttr = mlir::StringAttr::get(&Context, "foo");
mlir::Attribute ElementsAttr = mlir::DenseElementsAttr::get( mlir::Attribute ElementsAttr = mlir::DenseElementsAttr::get(
VectorType.cast<mlir::ShapedType>(), llvm::ArrayRef<float>{2.0f, 3.0f}); VectorType.cast<mlir::ShapedType>(), llvm::ArrayRef<float>{2.0f, 3.0f});
int main() { return 0; } int main() {
// Reference symbols that might otherwise be stripped.
std::uintptr_t result = 0;
auto dont_strip = [&](const auto &val) {
result += reinterpret_cast<std::uintptr_t>(&val);
};
dont_strip(Value);
return result; // Non-zero return value is OK.
}

cross-project-tests/debuginfo-tests/llvm-prettyprinters/gdb/mlir-support.gdb

Show All 18 Lines
# CHECK: "FooOp" # CHECK: "FooOp"
# CHECK-LABEL: +print Type # CHECK-LABEL: +print Type
print Type print Type
# CHECK: impl = 0x0 # CHECK: impl = 0x0
# CHECK-LABEL: +print IndexType # CHECK-LABEL: +print IndexType
print IndexType print IndexType
# CHECK: mlir::IndexType # CHECK: typeID = mlir::TypeID::get<mlir::IndexType>()
# CHECK-LABEL: +print IntegerType # CHECK-LABEL: +print IntegerType
print IntegerType print IntegerType
# CHECK: mlir::IntegerType # CHECK: typeID = mlir::TypeID::get<mlir::IntegerType>()
# CHECK: width = 3 # CHECK: members of mlir::detail::IntegerTypeStorage
# CHECK: Unsigned
# CHECK-LABEL: +print FloatType # CHECK-LABEL: +print FloatType
print FloatType print FloatType
# CHECK: mlir::Float32Type # CHECK: typeID = mlir::TypeID::get<mlir::Float32Type>()
# CHECK-LABEL: +print MemRefType # CHECK-LABEL: +print MemRefType
print MemRefType print MemRefType
# CHECK: mlir::MemRefType # CHECK: typeID = mlir::TypeID::get<mlir::MemRefType>()
# CHECK: shape = llvm::ArrayRef of length 2 = {4, 5} # CHECK: members of mlir::detail::MemRefTypeStorage
# CHECK: elementType
# CHECK: mlir::Float32Type
# CHECK-LABEL: +print UnrankedMemRefType # CHECK-LABEL: +print UnrankedMemRefType
print UnrankedMemRefType print UnrankedMemRefType
# CHECK: mlir::UnrankedMemRefType # CHECK: typeID = mlir::TypeID::get<mlir::UnrankedMemRefType>()
# CHECK: elementType # CHECK: members of mlir::detail::UnrankedMemRefTypeStorage
# CHECK: mlir::IntegerType
# CHECK: memorySpace
# CHECK: 6
# CHECK-LABEL: +print VectorType # CHECK-LABEL: +print VectorType
print VectorType print VectorType
# CHECK: mlir::VectorType # CHECK: typeID = mlir::TypeID::get<mlir::VectorType>()
# CHECK: shape = llvm::ArrayRef of length 2 = {1, 2} # CHECK: members of mlir::detail::VectorTypeStorage
# CHECK-LABEL: +print TupleType # CHECK-LABEL: +print TupleType
print TupleType print TupleType
# CHECK: mlir::TupleType # CHECK: typeID = mlir::TypeID::get<mlir::TupleType>()
# CHECK: numElements = 2
# CHECK: elements[0] # CHECK: elements[0]
# CHECK: mlir::IndexType # CHECK-NEXT: typeID = mlir::TypeID::get<mlir::IndexType>()
# CHECK: elements[1] # CHECK: elements[1]
# CHECK: mlir::Float32Type # CHECK-NEXT: typeID = mlir::TypeID::get<mlir::Float32Type>()
# CHECK-LABEL: +print Result # CHECK-LABEL: +print Result
print Result print Result
# CHECK: mlir::Float32Type # CHECK: typeID = mlir::TypeID::get<mlir::Float32Type>()
# CHECK: outOfLineIndex = 42 # CHECK: outOfLineIndex = 42
# CHECK-LABEL: +print Value # CHECK-LABEL: +print Value
print Value print Value
# CHECK: OutOfLineOpResult # CHECK: typeID = mlir::TypeID::get<mlir::Float32Type>()
# CHECK: mlir::detail::ValueImpl::Kind::OutOfLineOpResult
# CHECK-LABEL: +print UnknownLoc # CHECK-LABEL: +print UnknownLoc
print UnknownLoc print UnknownLoc
# CHECK: mlir::UnknownLoc # CHECK: typeID = mlir::TypeID::get<mlir::UnknownLoc>()
# CHECK-LABEL: +print FileLineColLoc # CHECK-LABEL: +print FileLineColLoc
print FileLineColLoc print FileLineColLoc
# CHECK: mlir::FileLineColLoc # CHECK: typeID = mlir::TypeID::get<mlir::FileLineColLoc>()
# CHECK: members of mlir::detail::FileLineColLocAttrStorage
# CHECK: "file" # CHECK: "file"
# CHECK: line = 7 # CHECK: line = 7
# CHECK: column = 8 # CHECK: column = 8
# CHECK-LABEL: +print OpaqueLoc # CHECK-LABEL: +print OpaqueLoc
print OpaqueLoc print OpaqueLoc
# CHECK: mlir::OpaqueLoc # CHECK: typeID = mlir::TypeID::get<mlir::OpaqueLoc>()
# CHECK: members of mlir::detail::OpaqueLocAttrStorage
# CHECK: underlyingLocation = 9 # CHECK: underlyingLocation = 9
# CHECK-LABEL: +print NameLoc # CHECK-LABEL: +print NameLoc
print NameLoc print NameLoc
# CHECK: mlir::NameLoc # CHECK: typeID = mlir::TypeID::get<mlir::NameLoc>()
# CHECK: members of mlir::detail::NameLocAttrStorage
# CHECK: "foo" # CHECK: "foo"
# CHECK: mlir::UnknownLoc # CHECK: typeID = mlir::TypeID::get<mlir::UnknownLoc>()
# CHECK-LABEL: +print CallSiteLoc # CHECK-LABEL: +print CallSiteLoc
print CallSiteLoc print CallSiteLoc
# CHECK: mlir::CallSiteLoc # CHECK: typeID = mlir::TypeID::get<mlir::CallSiteLoc>()
# CHECK: callee # CHECK: members of mlir::detail::CallSiteLocAttrStorage
# CHECK: mlir::FileLineColLoc # CHECK: typeID = mlir::TypeID::get<mlir::FileLineColLoc>()
# CHECK: caller # CHECK: typeID = mlir::TypeID::get<mlir::OpaqueLoc>()
# CHECK: mlir::OpaqueLoc
# CHECK-LABEL: +print FusedLoc # CHECK-LABEL: +print FusedLoc
print FusedLoc print FusedLoc
# CHECK: mlir::FusedLoc # CHECK: typeID = mlir::TypeID::get<mlir::FusedLoc>()
# CHECK: members of mlir::detail::FusedLocAttrStorage
# CHECK: locations = llvm::ArrayRef of length 2 # CHECK: locations = llvm::ArrayRef of length 2
# CHECK: mlir::FileLineColLoc # CHECK: typeID = mlir::TypeID::get<mlir::FileLineColLoc>()
# CHECK: mlir::NameLoc # CHECK: typeID = mlir::TypeID::get<mlir::NameLoc>()
# CHECK-LABEL: +print UnitAttr # CHECK-LABEL: +print UnitAttr
print UnitAttr print UnitAttr
# CHECK: mlir::UnitAttr # CHECK: typeID = mlir::TypeID::get<mlir::UnitAttr>()
# CHECK-LABEL: +print FloatAttr # CHECK-LABEL: +print FloatAttr
print FloatAttr print FloatAttr
# CHECK: mlir::FloatAttr # CHECK: typeID = mlir::TypeID::get<mlir::FloatAttr>()
# CHECK: members of mlir::detail::FloatAttrStorage
# CHECK-LABEL: +print IntegerAttr # CHECK-LABEL: +print IntegerAttr
print IntegerAttr print IntegerAttr
# CHECK: mlir::IntegerAttr # CHECK: typeID = mlir::TypeID::get<mlir::IntegerAttr>()
# CHECK: members of mlir::detail::IntegerAttrStorage
# CHECK-LABEL: +print TypeAttr # CHECK-LABEL: +print TypeAttr
print TypeAttr print TypeAttr
# CHECK: mlir::TypeAttr # CHECK: typeID = mlir::TypeID::get<mlir::TypeAttr>()
# CHECK: mlir::IndexType # CHECK: members of mlir::detail::TypeAttrStorage
# CHECK: typeID = mlir::TypeID::get<mlir::IndexType>()
# CHECK-LABEL: +print ArrayAttr # CHECK-LABEL: +print ArrayAttr
print ArrayAttr print ArrayAttr
# CHECK: mlir::ArrayAttr # CHECK: typeID = mlir::TypeID::get<mlir::ArrayAttr>()
# CHECK: members of mlir::detail::ArrayAttrStorage
# CHECK: llvm::ArrayRef of length 1 # CHECK: llvm::ArrayRef of length 1
# CHECK: mlir::UnitAttr # CHECK: typeID = mlir::TypeID::get<mlir::UnitAttr>()
# CHECK-LABEL: +print StringAttr # CHECK-LABEL: +print StringAttr
print StringAttr print StringAttr
# CHECK: mlir::StringAttr # CHECK: typeID = mlir::TypeID::get<mlir::StringAttr>()
# CHECK: members of mlir::detail::StringAttrStorage
# CHECK: value = "foo" # CHECK: value = "foo"
# CHECK-LABEL: +print ElementsAttr # CHECK-LABEL: +print ElementsAttr
print ElementsAttr print ElementsAttr
# CHECK: mlir::DenseIntOrFPElementsAttr # CHECK: typeID = mlir::TypeID::get<mlir::DenseIntOrFPElementsAttr>()
# CHECK: members of mlir::detail::DenseIntOrFPElementsAttrStorage