This is an archive of the discontinued LLVM Phabricator instance.

ARM: make FastISel & GISel pass -1 to ADJCALLSTACKUP to signal no callee pop.

Authored by t.p.northover on Jan 7 2022, 5:52 AM.



The interface for these instructions changed with support for mandatory tail calls, and now -1 indicates the CalleePopAmount argument is not valid. Unfortunately I didn't realise FastISel or GISel did calls at the time so didn't update them.

Should fix

Diff Detail

Event Timeline

t.p.northover created this revision.Jan 7 2022, 5:52 AM
t.p.northover requested review of this revision.Jan 7 2022, 5:52 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 7 2022, 5:52 AM
vit9696 accepted this revision.Jan 10 2022, 11:47 PM
vit9696 added a subscriber: vit9696.

Tested this on what we had on 13.x branch. Works fine. Thank you very much.

This revision is now accepted and ready to land.Jan 10 2022, 11:47 PM
t.p.northover closed this revision.Jan 11 2022, 3:31 AM

Thanks. Committed as 0b5b35fdbdbf.