This is an archive of the discontinued LLVM Phabricator instance.

Differential D116671

[mlir] Align LLVM_Type ODS constraint on type verifiers
ClosedPublic

Authored by ftynse on Jan 5 2022, 9:38 AM.

Details

Reviewers
wsmoses
Commits
rG06cc2f2f122a: [mlir] Align LLVM_Type ODS constraint on type verifiers
Summary

Verify only the outer type being LLVM-compatible, the elemental types if
present are already checked by the type verifiers. This makes some LLVM dialect
operations compatible with mixed-dialect types that appear during progressive
lowering.

Diff Detail

Event Timeline

ftynse created this revision.Jan 5 2022, 9:38 AM
Herald added subscribers: sdasgup3, wenzhicui, wrengr and 21 others. · View Herald TranscriptJan 5 2022, 9:38 AM
ftynse requested review of this revision.Jan 5 2022, 9:38 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 5 2022, 9:38 AM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
wsmoses accepted this revision.Jan 5 2022, 9:40 AM
This revision is now accepted and ready to land.Jan 5 2022, 9:40 AM
Harbormaster completed remote builds in B141705: Diff 397619.Jan 5 2022, 9:57 AM
Closed by commit rG06cc2f2f122a: [mlir] Align LLVM_Type ODS constraint on type verifiers (authored by ftynse). · Explain WhyJan 5 2022, 10:01 AM
This revision was automatically updated to reflect the committed changes.
ftynse added a commit: rG06cc2f2f122a: [mlir] Align LLVM_Type ODS constraint on type verifiers.

Revision Contents

PathSize
mlir/
include/
mlir/
Dialect/
LLVMIR/
2 lines
test/
Dialect/
LLVMIR/
2 lines

Diff 397627

mlir/include/mlir/Dialect/LLVMIR/LLVMOpBase.td

Show First 20 Lines • Show All 51 Lines • ▼ Show 20 Lines
} }
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// LLVM dialect type constraints. // LLVM dialect type constraints.
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// LLVM dialect type. // LLVM dialect type.
def LLVM_Type : DialectType<LLVM_Dialect, def LLVM_Type : DialectType<LLVM_Dialect,
CPred<"::mlir::LLVM::isCompatibleType($_self)">, CPred<"::mlir::LLVM::isCompatibleOuterType($_self)">,
"LLVM dialect-compatible type">; "LLVM dialect-compatible type">;
// Type constraint accepting LLVM token type. // Type constraint accepting LLVM token type.
def LLVM_TokenType : Type< def LLVM_TokenType : Type<
CPred<"$_self.isa<::mlir::LLVM::LLVMTokenType>()">, CPred<"$_self.isa<::mlir::LLVM::LLVMTokenType>()">,
"LLVM token type">, "LLVM token type">,
BuildableType<"::mlir::LLVM::LLVMTokenType::get($_builder.getContext())">; BuildableType<"::mlir::LLVM::LLVMTokenType::get($_builder.getContext())">;
▲ Show 20 Lines • Show All 290 Lines • Show Last 20 Lines

mlir/test/Dialect/LLVMIR/types.mlir

Show First 20 Lines • Show All 172 Lines • ▼ Show 20 Lines
func @verbose() { func @verbose() {
// CHECK: !llvm.struct<(i64, struct<(f32)>)> // CHECK: !llvm.struct<(i64, struct<(f32)>)>
"some.op"() : () -> !llvm.struct<(i64, !llvm.struct<(f32)>)> "some.op"() : () -> !llvm.struct<(i64, !llvm.struct<(f32)>)>
return return
} }
// CHECK-LABEL: @ptr_elem_interface // CHECK-LABEL: @ptr_elem_interface
// CHECK-COUNT-3: !llvm.ptr<!test.smpla> // CHECK-COUNT-3: !llvm.ptr<!test.smpla>
// CHECK: llvm.mlir.undef : !llvm.ptr<!test.smpla>
func @ptr_elem_interface(%arg0: !llvm.ptr<!test.smpla>) { func @ptr_elem_interface(%arg0: !llvm.ptr<!test.smpla>) {
%0 = llvm.load %arg0 : !llvm.ptr<!test.smpla> %0 = llvm.load %arg0 : !llvm.ptr<!test.smpla>
llvm.store %0, %arg0 : !llvm.ptr<!test.smpla> llvm.store %0, %arg0 : !llvm.ptr<!test.smpla>
llvm.mlir.undef : !llvm.ptr<!test.smpla>
return return
} }
// ----- // -----
// Check that type aliases can be used inside LLVM dialect types. Note that // Check that type aliases can be used inside LLVM dialect types. Note that
// currently they are _not_ printed back as this would require // currently they are _not_ printed back as this would require
// DialectAsmPrinter to have a mechanism for querying the presence and // DialectAsmPrinter to have a mechanism for querying the presence and
Show All 15 Lines