This is an archive of the discontinued LLVM Phabricator instance.

[clang-format][NFC] Fix typo in comment
ClosedPublic

Authored by pjessesco on Jan 5 2022, 5:42 AM.

Download Raw Diff

Details

Reviewers

MyDeveloperDay
curdeius

Commits

rG319971ca958a: [clang-format][NFC] Fix typo in comment

Summary

Fix typo (leftt -> left)

Diff Detail

Unit TestsFailed

	Time	Test
	150 ms	x64 debian > LLVM.Bindings/Go::go.test

Event Timeline

pjessesco requested review of this revision.Jan 5 2022, 5:42 AM

pjessesco created this revision.

Harbormaster completed remote builds in B141661: Diff 397548.Jan 5 2022, 6:57 AM

Eugene.Zelenko retitled this revision from [clang-format] Fix typo in comment to [clang-format][NFC] Fix typo in comment.Jan 5 2022, 7:08 AM

Eugene.Zelenko added a reviewer: MyDeveloperDay.

Eugene.Zelenko set the repository for this revision to rG LLVM Github Monorepo.

Eugene.Zelenko added a project: Restricted Project.

Eugene.Zelenko added a subscriber: cfe-commits.

Herald added a project: Restricted Project. · View Herald TranscriptJan 5 2022, 7:08 AM

LGTM.
You need someone to land it for you?

This revision is now accepted and ready to land.Jan 5 2022, 8:18 AM

Yes please, this is my first contribution in this project.

This revision was landed with ongoing or failed builds.Jan 5 2022, 8:33 AM

Closed by commit rG319971ca958a: [clang-format][NFC] Fix typo in comment (authored by pjessesco, committed by curdeius). · Explain Why

This revision was automatically updated to reflect the committed changes.

curdeius added a commit: rG319971ca958a: [clang-format][NFC] Fix typo in comment.

Welcome @pjessesco, not bad 1 day turn around on your first patch isn't bad!!

Revision Contents

Path

Size

clang/

lib/

Format/

WhitespaceManager.h

2 lines

Diff 397548

clang/lib/Format/WhitespaceManager.h

Show First 20 Lines • Show All 239 Lines • ▼ Show 20 Lines	private:
/// Align Array Initializers from change \p Start to change \p End at		/// Align Array Initializers from change \p Start to change \p End at
/// the specified \p Column.		/// the specified \p Column.
void alignArrayInitializers(unsigned Start, unsigned End);		void alignArrayInitializers(unsigned Start, unsigned End);

/// Align Array Initializers being careful to right justify the columns		/// Align Array Initializers being careful to right justify the columns
/// as described by \p CellDescs.		/// as described by \p CellDescs.
void alignArrayInitializersRightJustified(CellDescriptions &&CellDescs);		void alignArrayInitializersRightJustified(CellDescriptions &&CellDescs);

/// Align Array Initializers being careful to leftt justify the columns		/// Align Array Initializers being careful to left justify the columns
/// as described by \p CellDescs.		/// as described by \p CellDescs.
void alignArrayInitializersLeftJustified(CellDescriptions &&CellDescs);		void alignArrayInitializersLeftJustified(CellDescriptions &&CellDescs);

/// Calculate the cell width between two indexes.		/// Calculate the cell width between two indexes.
unsigned calculateCellWidth(unsigned Start, unsigned End,		unsigned calculateCellWidth(unsigned Start, unsigned End,
bool WithSpaces = false) const;		bool WithSpaces = false) const;

/// Get a set of fully specified CellDescriptions between \p Start and		/// Get a set of fully specified CellDescriptions between \p Start and
▲ Show 20 Lines • Show All 89 Lines • Show Last 20 Lines