This is an archive of the discontinued LLVM Phabricator instance.

Differential D116611

[clang][scandeps] Update Module Cache Path in Test
ClosedPublic

Authored by lenary on Jan 4 2022, 11:22 AM.

Details

Reviewers
rsmith
Bigcheese
simon_tatham
Commits
rG015e08c6bada: [clang][scandeps] Update Module Cache Path in Test
Summary

This fixes the test introduced in D114206 so it no longer writes to the current working directory.

Diff Detail

Unit TestsFailed

TimeTest
70 msx64 debian > LLVM.Bindings/Go::go.test

Event Timeline

lenary requested review of this revision.Jan 4 2022, 11:22 AM
lenary created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptJan 4 2022, 11:22 AM
Harbormaster completed remote builds in B141530: Diff 397351.Jan 4 2022, 11:55 AM
simon_tatham accepted this revision.Jan 5 2022, 2:35 AM
This revision is now accepted and ready to land.Jan 5 2022, 2:35 AM
This revision was landed with ongoing or failed builds.Jan 5 2022, 2:43 AM
Closed by commit rG015e08c6bada: [clang][scandeps] Update Module Cache Path in Test (authored by Archibald Elliott <archibald.elliott@arm.com>). · Explain Why
This revision was automatically updated to reflect the committed changes.
lenary added a commit: rG015e08c6bada: [clang][scandeps] Update Module Cache Path in Test.
lenary mentioned this in D114206: [Clang][ScanDeps] Use the virtual path for module maps.Jan 5 2022, 4:18 AM

Revision Contents

PathSize
clang/
test/
ClangScanDeps/
2 lines

Diff 397351

clang/test/ClangScanDeps/modulemap-via-vfs.m

Show All 9 Lines
// CHECK-NOT: build/module.modulemap // CHECK-NOT: build/module.modulemap
// CHECK: A/module.modulemap // CHECK: A/module.modulemap
//--- build/compile-commands.json.in //--- build/compile-commands.json.in
[ [
{ {
"directory": "DIR", "directory": "DIR",
"command": "clang DIR/main.m -Imodules/A -fmodules -fmodules-cache-path=module-cache -fimplicit-modules -fimplicit-module-maps -ivfsoverlay build/vfs.yaml", "command": "clang DIR/main.m -Imodules/A -fmodules -fmodules-cache-path=DIR/module-cache -fimplicit-modules -fimplicit-module-maps -ivfsoverlay build/vfs.yaml",
"file": "DIR/main.m" "file": "DIR/main.m"
} }
] ]
//--- build/module.modulemap //--- build/module.modulemap
module A { module A {
umbrella header "A.h" umbrella header "A.h"
Show All 30 Lines