This is an archive of the discontinued LLVM Phabricator instance.

Differential D116508

[llvm-profgen] Error out for unsupported AutoFDO profile generate with probe
ClosedPublic

Authored by wenlei on Jan 2 2022, 4:29 PM.

Details

Reviewers
wlei
hoy
Commits
rG9a2120a6e1fc: [llvm-profgen] Error out for unsupported AutoFDO profile generate with probe
Summary

Error out instead of siliently generate empty profile when trying to generate AutoFDO profile with probe binary.

Diff Detail

Unit TestsFailed

TimeTest
60 msx64 debian > LLVM.Bindings/Go::go.test

Event Timeline

wenlei created this revision.Jan 2 2022, 4:29 PM
Herald added a subscriber: modimo. · View Herald TranscriptJan 2 2022, 4:29 PM
wenlei requested review of this revision.Jan 2 2022, 4:29 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 2 2022, 4:29 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
wlei accepted this revision.Jan 2 2022, 4:30 PM

LGTM, thanks!

This revision is now accepted and ready to land.Jan 2 2022, 4:30 PM
wenlei updated this revision to Diff 396965.Jan 2 2022, 4:38 PM

update message.

This revision was landed with ongoing or failed builds.Jan 2 2022, 4:40 PM
Closed by commit rG9a2120a6e1fc: [llvm-profgen] Error out for unsupported AutoFDO profile generate with probe (authored by wenlei). · Explain Why
This revision was automatically updated to reflect the committed changes.
wenlei added a commit: rG9a2120a6e1fc: [llvm-profgen] Error out for unsupported AutoFDO profile generate with probe.
Harbormaster completed remote builds in B141259: Diff 396965.Jan 2 2022, 5:11 PM

Revision Contents

PathSize
llvm/
tools/
llvm-profgen/
2 lines

Diff 396965

llvm/tools/llvm-profgen/ProfileGenerator.cpp

Show First 20 Lines • Show All 377 Lines • ▼ Show 20 Lines if (Ret.second) {
FProfile.setContext(Context); FProfile.setContext(Context);
} }
return Ret.first->second; return Ret.first->second;
} }
void ProfileGenerator::generateProfile() { void ProfileGenerator::generateProfile() {
if (Binary->usePseudoProbes()) { if (Binary->usePseudoProbes()) {
// TODO: Support probe based profile generation // TODO: Support probe based profile generation
exitWithError("Probe based profile generation not supported for AutoFDO, "
"consider dropping `--ignore-stack-samples` or adding `--use-dwarf-correlation`.");
Lint: Pre-merge checks
Inline Actions

clang-format: please reformat the code

-     "consider dropping `--ignore-stack-samples` or adding `--use-dwarf-correlation`.");
+                  "consider dropping `--ignore-stack-samples` or adding "
+                  "`--use-dwarf-correlation`.");
Lint: Pre-merge checks: clang-format: please reformat the code ``` - "consider dropping `--ignore-stack-samples` or…
} else { } else {
generateLineNumBasedProfile(); generateLineNumBasedProfile();
} }
postProcessProfiles(); postProcessProfiles();
} }
void ProfileGenerator::postProcessProfiles() { void ProfileGenerator::postProcessProfiles() {
computeSummaryAndThreshold(); computeSummaryAndThreshold();
▲ Show 20 Lines • Show All 584 Lines • Show Last 20 Lines