This is an archive of the discontinued LLVM Phabricator instance.

[mips][microMIPS] Implement LWLE, LWRE, SWLE and SWRE instructions
ClosedPublic

Authored by hvarga on Jul 30 2015, 12:12 AM.

Details

Summary

The patch implements microMIPS LWLE, LWRE, SWLE and SWRE instructions.

Diff Detail

Event Timeline

hvarga updated this revision to Diff 31000.Jul 30 2015, 12:12 AM
hvarga retitled this revision from to [mips][microMIPS] Implement LWLE, LWRE, SWLE and SWRE instructions.
hvarga updated this object.
hvarga added subscribers: petarj, llvm-commits.
dsanders accepted this revision.Sep 14 2015, 7:13 AM
dsanders edited edge metadata.

LGTM with some nits

lib/Target/Mips/Disassembler/MipsDisassembler.cpp
288–290

Indentation

lib/Target/Mips/MicroMipsInstrFormats.td
405

Naming convention: Should begin with POOL32C_

407

Assign to 'base' and 'offset' to make special encoding self documenting

lib/Target/Mips/MicroMipsInstrInfo.td
717–726

Indentation

This revision is now accepted and ready to land.Sep 14 2015, 7:13 AM
This revision was automatically updated to reflect the committed changes.