The patch implements microMIPS LWLE, LWRE, SWLE and SWRE instructions.
Details
Details
Diff Detail
Diff Detail
Event Timeline
Comment Actions
LGTM with some nits
lib/Target/Mips/Disassembler/MipsDisassembler.cpp | ||
---|---|---|
288–290 | Indentation | |
lib/Target/Mips/MicroMipsInstrFormats.td | ||
405 | Naming convention: Should begin with POOL32C_ | |
407 | Assign to 'base' and 'offset' to make special encoding self documenting | |
lib/Target/Mips/MicroMipsInstrInfo.td | ||
717–726 | Indentation |
Indentation