This is an archive of the discontinued LLVM Phabricator instance.

Differential D116149

[IR] Add memory attributes for init.trampoline
ClosedPublic

Authored by nikic on Dec 22 2021, 2:39 AM.

Details

Reviewers
reames
fhahn
jdoerfert
Commits
rG510d0e493365: [IR] Add memory attributes for init.trampoline
Summary

Based on my reading of https://llvm.org/docs/LangRef.html#llvm-init-trampoline-intrinsic, init.trampoline writes to the first argument, while the other two are readnone. These two arguments are only captured and written into the trampoline memory. This also matches what I see in the X86TargetLowering::LowerINIT_TRAMPOLINE() implementation.

Unfortunately the person who originally worked on trampolines doesn't seem to be active anymore, so adding some general memory attribute reviewers... I hope that with this change we can remove special intrinsic handling in MemoryLocation::getForDest().

Diff Detail

Unit TestsFailed

TimeTest
60 msx64 debian > LLVM.Bindings/Go::go.test

Event Timeline

nikic created this revision.Dec 22 2021, 2:39 AM
Herald added a subscriber: pengfei. · View Herald TranscriptDec 22 2021, 2:39 AM
nikic requested review of this revision.Dec 22 2021, 2:39 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 22 2021, 2:39 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B140357: Diff 395819.Dec 22 2021, 3:23 AM
jdoerfert accepted this revision.Dec 22 2021, 2:09 PM

No trampoline knowledge but from the description this seems to make sense. Let's go with it and if it causes problems we update the lang ref accordingly.

This revision is now accepted and ready to land.Dec 22 2021, 2:09 PM
This revision was landed with ongoing or failed builds.Dec 23 2021, 12:02 AM
Closed by commit rG510d0e493365: [IR] Add memory attributes for init.trampoline (authored by nikic). · Explain Why
This revision was automatically updated to reflect the committed changes.
nikic added a commit: rG510d0e493365: [IR] Add memory attributes for init.trampoline.

Revision Contents

PathSize
llvm/
include/
llvm/
IR/
5 lines

Diff 395819

llvm/include/llvm/IR/Intrinsics.td

Show First 20 Lines • Show All 1,013 Lines • ▼ Show 20 Lines
def int_codeview_annotation : DefaultAttrsIntrinsic<[], [llvm_metadata_ty], def int_codeview_annotation : DefaultAttrsIntrinsic<[], [llvm_metadata_ty],
[IntrInaccessibleMemOnly, IntrNoDuplicate, IntrWillReturn], [IntrInaccessibleMemOnly, IntrNoDuplicate, IntrWillReturn],
"llvm.codeview.annotation">; "llvm.codeview.annotation">;
//===------------------------ Trampoline Intrinsics -----------------------===// //===------------------------ Trampoline Intrinsics -----------------------===//
// //
def int_init_trampoline : Intrinsic<[], def int_init_trampoline : Intrinsic<[],
[llvm_ptr_ty, llvm_ptr_ty, llvm_ptr_ty], [llvm_ptr_ty, llvm_ptr_ty, llvm_ptr_ty],
[IntrArgMemOnly, NoCapture<ArgIndex<0>>]>, [IntrArgMemOnly, NoCapture<ArgIndex<0>>,
WriteOnly<ArgIndex<0>>,
ReadNone<ArgIndex<1>>,
ReadNone<ArgIndex<2>>]>,
GCCBuiltin<"__builtin_init_trampoline">; GCCBuiltin<"__builtin_init_trampoline">;
def int_adjust_trampoline : Intrinsic<[llvm_ptr_ty], [llvm_ptr_ty], def int_adjust_trampoline : Intrinsic<[llvm_ptr_ty], [llvm_ptr_ty],
[IntrReadMem, IntrArgMemOnly]>, [IntrReadMem, IntrArgMemOnly]>,
GCCBuiltin<"__builtin_adjust_trampoline">; GCCBuiltin<"__builtin_adjust_trampoline">;
//===------------------------ Overflow Intrinsics -------------------------===// //===------------------------ Overflow Intrinsics -------------------------===//
// //
▲ Show 20 Lines • Show All 897 Lines • Show Last 20 Lines