This is an archive of the discontinued LLVM Phabricator instance.

Differential D116122

[libc] Add performance tests for hypotf and hypot.
ClosedPublic

Authored by lntue on Dec 21 2021, 11:24 AM.

Details

Reviewers
sivachandra
michaelrj
Commits
rG12779edd7118: [libc] Add performance tests for hypotf and hypot.
Summary

Add performance tests for hypotf and hypot.

Diff Detail

Event Timeline

lntue created this revision.Dec 21 2021, 11:24 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 21 2021, 11:24 AM
Herald added subscribers: ecnelises, tschuett, mgorny. · View Herald Transcript
lntue requested review of this revision.Dec 21 2021, 11:24 AM
Harbormaster completed remote builds in B140289: Diff 395729.Dec 21 2021, 11:29 AM
michaelrj accepted this revision.Dec 22 2021, 10:43 AM

LGTM with some formatting nits

libc/test/src/math/differential_testing/BinaryOpSingleOutputDiff.h
21

Constexpr variables should be UPPER_CASE

52

Normal variables should be lower_case

This revision is now accepted and ready to land.Dec 22 2021, 10:43 AM
sivachandra added inline comments.Dec 22 2021, 1:29 PM
libc/test/src/math/differential_testing/BinaryOpSingleOutputDiff.h
52

Function/method names should also be formatted in the same fashion.

lntue updated this revision to Diff 395927.Dec 22 2021, 2:04 PM

[libc] Add performance tests for hypotf and hypot.

Harbormaster completed remote builds in B140439: Diff 395927.Dec 22 2021, 2:10 PM
sivachandra accepted this revision.Dec 22 2021, 3:31 PM
sivachandra added inline comments.
libc/test/src/math/differential_testing/BinaryOpSingleOutputDiff.h
26

Method name and param names should also in lower_case style.

lntue updated this revision to Diff 395969.Dec 22 2021, 9:36 PM
lntue marked 4 inline comments as done.

[libc] Add performance tests for hypotf and hypot.

lntue updated this revision to Diff 395972.Dec 22 2021, 9:39 PM

[libc] Add performance tests for hypotf and hypot.

Harbormaster completed remote builds in B140472: Diff 395972.Dec 22 2021, 9:44 PM
Closed by commit rG12779edd7118: [libc] Add performance tests for hypotf and hypot. (authored by lntue). · Explain WhyDec 22 2021, 9:45 PM
This revision was automatically updated to reflect the committed changes.
lntue added a commit: rG12779edd7118: [libc] Add performance tests for hypotf and hypot..

Revision Contents

PathSize
libc/
test/
src/
math/
differential_testing/
99 lines
28 lines
16 lines
16 lines

Diff 395973

libc/test/src/math/differential_testing/BinaryOpSingleOutputDiff.h

  • This file was added.
//===-- Common utility class for differential analysis --------------------===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
#include "src/__support/FPUtil/FPBits.h"
#include "utils/testutils/StreamWrapper.h"
#include "utils/testutils/Timer.h"
namespace __llvm_libc {
namespace testing {
template <typename T> class BinaryOpSingleOutputDiff {
using FPBits = fputil::FPBits<T>;
using UIntType = typename FPBits::UIntType;
static constexpr UIntType MSBIT = UIntType(1) << (8 * sizeof(UIntType) - 1);
static constexpr UIntType UINTMAX = (MSBIT - 1) + MSBIT;
michaelrjUnsubmitted
Done
ReplyInline Actions

Constexpr variables should be UPPER_CASE

michaelrj: Constexpr variables should be UPPER_CASE
public:
typedef T Func(T, T);
static void run_perf_in_range(Func myFunc, Func otherFunc,
UIntType startingBit, UIntType endingBit,
sivachandraUnsubmitted
Done
ReplyInline Actions

Method name and param names should also in lower_case style.

sivachandra: Method name and param names should also in `lower_case` style.
UIntType N, testutils::OutputFileStream &log) {
auto runner = [=](Func func) {
volatile T result;
if (endingBit < startingBit) {
return;
}
UIntType step = (endingBit - startingBit) / N;
for (UIntType bitsX = startingBit, bitsY = endingBit;;
bitsX += step, bitsY -= step) {
T x = T(FPBits(bitsX));
T y = T(FPBits(bitsY));
result = func(x, y);
if (endingBit - bitsX < step) {
break;
}
}
};
Timer timer;
timer.start();
runner(myFunc);
timer.stop();
double my_average = static_cast<double>(timer.nanoseconds()) / N;
log << "-- My function --\n";
michaelrjUnsubmitted
Done
ReplyInline Actions

Normal variables should be lower_case

michaelrj: Normal variables should be lower_case
sivachandraUnsubmitted
Done
ReplyInline Actions

Function/method names should also be formatted in the same fashion.

sivachandra: Function/method names should also be formatted in the same fashion.
log << " Total time : " << timer.nanoseconds() << " ns \n";
log << " Average runtime : " << my_average << " ns/op \n";
log << " Ops per second : "
<< static_cast<uint64_t>(1'000'000'000.0 / my_average) << " op/s \n";
timer.start();
runner(otherFunc);
timer.stop();
double other_average = static_cast<double>(timer.nanoseconds()) / N;
log << "-- Other function --\n";
log << " Total time : " << timer.nanoseconds() << " ns \n";
log << " Average runtime : " << other_average << " ns/op \n";
log << " Ops per second : "
<< static_cast<uint64_t>(1'000'000'000.0 / other_average) << " op/s \n";
log << "-- Average runtime ratio --\n";
log << " Mine / Other's : " << my_average / other_average << " \n";
}
static void run_perf(Func myFunc, Func otherFunc, const char *logFile) {
testutils::OutputFileStream log(logFile);
log << " Performance tests with inputs in denormal range:\n";
run_perf_in_range(myFunc, otherFunc, /* startingBit= */ UIntType(0),
/* endingBit= */ FPBits::MAX_SUBNORMAL, 1'000'001, log);
log << "\n Performance tests with inputs in normal range:\n";
run_perf_in_range(myFunc, otherFunc, /* startingBit= */ FPBits::MIN_NORMAL,
/* endingBit= */ FPBits::MAX_NORMAL, 100'000'001, log);
}
};
} // namespace testing
} // namespace __llvm_libc
#define BINARY_OP_SINGLE_OUTPUT_DIFF(T, myFunc, otherFunc, filename) \
int main() { \
__llvm_libc::testing::BinaryOpSingleOutputDiff<T>::run_diff( \
&myFunc, &otherFunc, filename); \
return 0; \
}
#define BINARY_OP_SINGLE_OUTPUT_PERF(T, myFunc, otherFunc, filename) \
int main() { \
__llvm_libc::testing::BinaryOpSingleOutputDiff<T>::run_perf( \
&myFunc, &otherFunc, filename); \
return 0; \
}

libc/test/src/math/differential_testing/CMakeLists.txt

Show First 20 Lines • Show All 61 Lines • ▼ Show 20 Lines
endfunction() endfunction()
add_header_library( add_header_library(
single_input_single_output_diff single_input_single_output_diff
HDRS HDRS
SingleInputSingleOutputDiff.h SingleInputSingleOutputDiff.h
) )
add_header_library(
binary_op_single_output_diff
HDRS
BinaryOpSingleOutputDiff.h
)
add_diff_binary( add_diff_binary(
sinf_diff sinf_diff
SRCS SRCS
sinf_diff.cpp sinf_diff.cpp
DEPENDS DEPENDS
.single_input_single_output_diff .single_input_single_output_diff
libc.src.math.sinf libc.src.math.sinf
) )
▲ Show 20 Lines • Show All 285 Lines • ▼ Show 20 Linesadd_diff_binary(
SRCS SRCS
truncf_perf.cpp truncf_perf.cpp
DEPENDS DEPENDS
.single_input_single_output_diff .single_input_single_output_diff
libc.src.math.truncf libc.src.math.truncf
COMPILE_OPTIONS COMPILE_OPTIONS
-fno-builtin -fno-builtin
) )
add_diff_binary(
hypotf_perf
SRCS
hypotf_perf.cpp
DEPENDS
.binary_op_single_output_diff
libc.src.math.hypotf
COMPILE_OPTIONS
-fno-builtin
)
add_diff_binary(
hypot_perf
SRCS
hypot_perf.cpp
DEPENDS
.binary_op_single_output_diff
libc.src.math.hypot
COMPILE_OPTIONS
-fno-builtin
)

libc/test/src/math/differential_testing/hypot_perf.cpp

  • This file was added.
//===-- Differential test for hypot ---------------------------------------===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
#include "BinaryOpSingleOutputDiff.h"
#include "src/math/hypot.h"
#include <math.h>
BINARY_OP_SINGLE_OUTPUT_PERF(double, __llvm_libc::hypot, ::hypot,
"hypot_perf.log")

libc/test/src/math/differential_testing/hypotf_perf.cpp

  • This file was added.
//===-- Differential test for hypotf --------------------------------------===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
#include "BinaryOpSingleOutputDiff.h"
#include "src/math/hypotf.h"
#include <math.h>
BINARY_OP_SINGLE_OUTPUT_PERF(float, __llvm_libc::hypotf, ::hypotf,
"hypotf_perf.log")