This is an archive of the discontinued LLVM Phabricator instance.

Differential D116121

[ASan] Change optimized callbacks visibility to hidden.
ClosedPublic

Authored by kstoimenov on Dec 21 2021, 11:14 AM.

Details

Reviewers
vitalybuka
Commits
rG2477e69c6df5: [ASan] Change optimized callbacks visibility to hidden.
Summary

Making callbacks hidden will remove PLT calls.

Diff Detail

Unit TestsFailed

TimeTest
120 msx64 debian > LLVM.Bindings/Go::go.test

Event Timeline

kstoimenov requested review of this revision.Dec 21 2021, 11:14 AM
kstoimenov created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptDec 21 2021, 11:14 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript
kstoimenov added a reviewer: vitalybuka.Dec 21 2021, 11:15 AM
Harbormaster completed remote builds in B140287: Diff 395725.Dec 21 2021, 11:34 AM
vitalybuka accepted this revision.Dec 21 2021, 11:49 AM
This revision is now accepted and ready to land.Dec 21 2021, 11:49 AM
This revision was landed with ongoing or failed builds.Dec 21 2021, 1:33 PM
Closed by commit rG2477e69c6df5: [ASan] Change optimized callbacks visibility to hidden. (authored by kstoimenov). · Explain Why
This revision was automatically updated to reflect the committed changes.
kstoimenov added a commit: rG2477e69c6df5: [ASan] Change optimized callbacks visibility to hidden..

Revision Contents

PathSize
compiler-rt/
lib/
asan/
33 lines
1 line

Diff 395725

compiler-rt/lib/asan/asan_interface.inc

Show First 20 Lines • Show All 174 Lines • ▼ Show 20 Lines
INTERFACE_FUNCTION(__sanitizer_unaligned_load64) INTERFACE_FUNCTION(__sanitizer_unaligned_load64)
INTERFACE_FUNCTION(__sanitizer_unaligned_store16) INTERFACE_FUNCTION(__sanitizer_unaligned_store16)
INTERFACE_FUNCTION(__sanitizer_unaligned_store32) INTERFACE_FUNCTION(__sanitizer_unaligned_store32)
INTERFACE_FUNCTION(__sanitizer_unaligned_store64) INTERFACE_FUNCTION(__sanitizer_unaligned_store64)
INTERFACE_FUNCTION(__asan_update_allocation_context) INTERFACE_FUNCTION(__asan_update_allocation_context)
INTERFACE_WEAK_FUNCTION(__asan_default_options) INTERFACE_WEAK_FUNCTION(__asan_default_options)
INTERFACE_WEAK_FUNCTION(__asan_default_suppressions) INTERFACE_WEAK_FUNCTION(__asan_default_suppressions)
INTERFACE_WEAK_FUNCTION(__asan_on_error) INTERFACE_WEAK_FUNCTION(__asan_on_error)
#if defined(__x86_64__) && !defined(__APPLE__) && !defined(SANITIZER_WINDOWS)
# define ASAN_MEMORY_ACCESS_CALLBACK_ADD(s, reg, op) \
INTERFACE_FUNCTION(__asan_check_##op##_add_##s##_##reg)
# define ASAN_MEMORY_ACCESS_CALLBACKS_ADD(reg) \
ASAN_MEMORY_ACCESS_CALLBACK_ADD(1, reg, load) \
ASAN_MEMORY_ACCESS_CALLBACK_ADD(1, reg, store) \
ASAN_MEMORY_ACCESS_CALLBACK_ADD(2, reg, load) \
ASAN_MEMORY_ACCESS_CALLBACK_ADD(2, reg, store) \
ASAN_MEMORY_ACCESS_CALLBACK_ADD(4, reg, load) \
ASAN_MEMORY_ACCESS_CALLBACK_ADD(4, reg, store) \
ASAN_MEMORY_ACCESS_CALLBACK_ADD(8, reg, load) \
ASAN_MEMORY_ACCESS_CALLBACK_ADD(8, reg, store) \
ASAN_MEMORY_ACCESS_CALLBACK_ADD(16, reg, load) \
ASAN_MEMORY_ACCESS_CALLBACK_ADD(16, reg, store)
ASAN_MEMORY_ACCESS_CALLBACKS_ADD(RAX)
ASAN_MEMORY_ACCESS_CALLBACKS_ADD(RBX)
ASAN_MEMORY_ACCESS_CALLBACKS_ADD(RCX)
ASAN_MEMORY_ACCESS_CALLBACKS_ADD(RDX)
ASAN_MEMORY_ACCESS_CALLBACKS_ADD(RSI)
ASAN_MEMORY_ACCESS_CALLBACKS_ADD(RDI)
ASAN_MEMORY_ACCESS_CALLBACKS_ADD(RBP)
ASAN_MEMORY_ACCESS_CALLBACKS_ADD(R8)
ASAN_MEMORY_ACCESS_CALLBACKS_ADD(R9)
ASAN_MEMORY_ACCESS_CALLBACKS_ADD(R12)
ASAN_MEMORY_ACCESS_CALLBACKS_ADD(R13)
ASAN_MEMORY_ACCESS_CALLBACKS_ADD(R14)
ASAN_MEMORY_ACCESS_CALLBACKS_ADD(R15)
#endif // defined(__x86_64__)

compiler-rt/lib/asan/asan_rtl_x86_64.S

Show All 10 Lines
#define FNAME(reg, op, s, i) NAME(__asan_check, reg, op, s, i) #define FNAME(reg, op, s, i) NAME(__asan_check, reg, op, s, i)
#define RLABEL(reg, op, s, i) NAME(.return, reg, op, s, i) #define RLABEL(reg, op, s, i) NAME(.return, reg, op, s, i)
#define CLABEL(reg, op, s, i) NAME(.check, reg, op, s, i) #define CLABEL(reg, op, s, i) NAME(.check, reg, op, s, i)
#define FLABEL(reg, op, s, i) NAME(.fail, reg, op, s, i) #define FLABEL(reg, op, s, i) NAME(.fail, reg, op, s, i)
#define BEGINF(reg, op, s, i) \ #define BEGINF(reg, op, s, i) \
.globl FNAME(reg, op, s, i) ;\ .globl FNAME(reg, op, s, i) ;\
.hidden FNAME(reg, op, s, i) ;\
ASM_TYPE_FUNCTION(FNAME(reg, op, s, i)) ;\ ASM_TYPE_FUNCTION(FNAME(reg, op, s, i)) ;\
.cfi_startproc ;\ .cfi_startproc ;\
FNAME(reg, op, s, i): ;\ FNAME(reg, op, s, i): ;\
#define ENDF .cfi_endproc ;\ #define ENDF .cfi_endproc ;\
// Access check functions for 1,2 and 4 byte types, which require extra checks. // Access check functions for 1,2 and 4 byte types, which require extra checks.
#define ASAN_MEMORY_ACCESS_INITIAL_CHECK_ADD(reg, op, s) \ #define ASAN_MEMORY_ACCESS_INITIAL_CHECK_ADD(reg, op, s) \
▲ Show 20 Lines • Show All 119 Lines • Show Last 20 Lines