Depends on D108371
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Time | Test | |
---|---|---|
60,170 ms | x64 debian > AddressSanitizer-x86_64-linux.TestCases::scariness_score_test.cpp Script:
--
: 'RUN: at line 4'; /var/lib/buildkite-agent/builds/llvm-project/build/./bin/clang --driver-mode=g++ -fsanitize=address -mno-omit-leaf-frame-pointer -fno-omit-frame-pointer -fno-optimize-sibling-calls -gline-tables-only -m64 -O0 /var/lib/buildkite-agent/builds/llvm-project/compiler-rt/test/asan/TestCases/scariness_score_test.cpp -o /var/lib/buildkite-agent/builds/llvm-project/build/projects/compiler-rt/test/asan/X86_64LinuxConfig/TestCases/Output/scariness_score_test.cpp.tmp
| |
60,140 ms | x64 debian > Clang.CodeGen/RISCV/rvv-intrinsics::vloxseg.c Script:
--
: 'RUN: at line 3'; /var/lib/buildkite-agent/builds/llvm-project/build/bin/clang -cc1 -internal-isystem /var/lib/buildkite-agent/builds/llvm-project/build/lib/clang/15.0.0/include -nostdsysteminc -triple riscv64 -target-feature +f -target-feature +d -target-feature +zfh -target-feature +v -disable-O0-optnone -emit-llvm /var/lib/buildkite-agent/builds/llvm-project/clang/test/CodeGen/RISCV/rvv-intrinsics/vloxseg.c -o - | /var/lib/buildkite-agent/builds/llvm-project/build/bin/opt -S -mem2reg | /var/lib/buildkite-agent/builds/llvm-project/build/bin/FileCheck --check-prefix=CHECK-RV64 /var/lib/buildkite-agent/builds/llvm-project/clang/test/CodeGen/RISCV/rvv-intrinsics/vloxseg.c
| |
60,230 ms | x64 debian > Clang.CodeGen/RISCV/rvv-intrinsics::vluxseg.c Script:
--
: 'RUN: at line 3'; /var/lib/buildkite-agent/builds/llvm-project/build/bin/clang -cc1 -internal-isystem /var/lib/buildkite-agent/builds/llvm-project/build/lib/clang/15.0.0/include -nostdsysteminc -triple riscv64 -target-feature +f -target-feature +d -target-feature +zfh -target-feature +v -disable-O0-optnone -emit-llvm /var/lib/buildkite-agent/builds/llvm-project/clang/test/CodeGen/RISCV/rvv-intrinsics/vluxseg.c -o - | /var/lib/buildkite-agent/builds/llvm-project/build/bin/opt -S -mem2reg | /var/lib/buildkite-agent/builds/llvm-project/build/bin/FileCheck --check-prefix=CHECK-RV64 /var/lib/buildkite-agent/builds/llvm-project/clang/test/CodeGen/RISCV/rvv-intrinsics/vluxseg.c
| |
60,140 ms | x64 debian > Clang.CodeGen/RISCV/rvv-intrinsics-overloaded::vloxseg.c Script:
--
: 'RUN: at line 3'; /var/lib/buildkite-agent/builds/llvm-project/build/bin/clang -cc1 -internal-isystem /var/lib/buildkite-agent/builds/llvm-project/build/lib/clang/15.0.0/include -nostdsysteminc -triple riscv64 -target-feature +f -target-feature +d -target-feature +v -disable-O0-optnone -emit-llvm /var/lib/buildkite-agent/builds/llvm-project/clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vloxseg.c -o - | /var/lib/buildkite-agent/builds/llvm-project/build/bin/opt -S -mem2reg | /var/lib/buildkite-agent/builds/llvm-project/build/bin/FileCheck --check-prefix=CHECK-RV64 /var/lib/buildkite-agent/builds/llvm-project/clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vloxseg.c
| |
60,140 ms | x64 debian > Clang.CodeGen/RISCV/rvv-intrinsics-overloaded::vluxseg.c Script:
--
: 'RUN: at line 3'; /var/lib/buildkite-agent/builds/llvm-project/build/bin/clang -cc1 -internal-isystem /var/lib/buildkite-agent/builds/llvm-project/build/lib/clang/15.0.0/include -nostdsysteminc -triple riscv64 -target-feature +f -target-feature +d -target-feature +v -disable-O0-optnone -emit-llvm /var/lib/buildkite-agent/builds/llvm-project/clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vluxseg.c -o - | /var/lib/buildkite-agent/builds/llvm-project/build/bin/opt -S -mem2reg | /var/lib/buildkite-agent/builds/llvm-project/build/bin/FileCheck --check-prefix=CHECK-RV64 /var/lib/buildkite-agent/builds/llvm-project/clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vluxseg.c
| |
View Full Test Results (10 Failed) |
Event Timeline
llvm/test/Transforms/LoopVectorize/X86/vectorization-remarks-missed.ll | ||
---|---|---|
200 | This change is to address the comment: https://reviews.llvm.org/D108371#inline-1093152 I've updated the debug info in the test to point the loop to |
- Added YAML to LIT test
(This is in response to https://reviews.llvm.org/D108371#inline-1112148)
llvm/lib/Analysis/LoopAccessAnalysis.cpp | ||
---|---|---|
563 | Instead of passing in the pointer with a default value of nullptr, can you make it a reference, so that it always gets set, e.g. Value *&UncomputablePtr That also removes the need for the conditional write. | |
llvm/test/Transforms/LoopVectorize/X86/vectorization-remarks-missed.ll | ||
200 | Is this an unrelated change? |
llvm/lib/Analysis/LoopAccessAnalysis.cpp | ||
---|---|---|
563 | Can we please leave it as initialised as nullptr ? The conditional write ensures that the first unsafe dependence gets reported by the remark. if (UncomputablePtr) *UncomputablePtr = Access.getPointer(); | |
llvm/test/Transforms/LoopVectorize/X86/vectorization-remarks-missed.ll | ||
200 | Ok. I've submitted as a separate commit to avoid any confusion. |
llvm/lib/Analysis/LoopAccessAnalysis.cpp | ||
---|---|---|
563 | Ok please ignore the above. I've made the change as suggested, But I didn't remove that bit in the code. if (!UncomputablePtr) UncomputablePtr = Access.getPointer(); |
llvm/lib/Analysis/LoopAccessAnalysis.cpp | ||
---|---|---|
563 |
That should be the choice of the caller, not the callee. If the caller doesn't want the value to be overwritten, it should pass a dummy variable | |
823 | I believe this check should be removed (see my other comment as well) | |
2106–2108 | This variable aliases with UncomputablePtr defined on line 2075. Either pass in the same variable, or give this variable a different name. |
llvm/lib/Analysis/LoopAccessAnalysis.cpp | ||
---|---|---|
2078–2079 | Before this change, recordAnalysis was called unconditionally, but now it is only called if UncomputablePtr is set. I don't think that's intentional, so you can instead just do this: auto *I = dyn_cast_or_null<Instruction>(UncomputablePtr); recordAnalysis("CantIdentifyArrayBounds", I) << "cannot identify array bounds"; | |
2106–2108 | nit: s/UncomputablePtr2/UncomputablePtrUnused/ |
llvm/lib/Analysis/LoopAccessAnalysis.cpp | ||
---|---|---|
2106–2108 | nit: I'm not really a fan of the name, so personally I would prefer to reuse the old variable, e.g. reset it first: UncomputablePtr = nullptr; and then pass that into canCheckPtrAtRT. |