This is an archive of the discontinued LLVM Phabricator instance.

[clang-format] put non-empty catch block on one line with AllowShortBlocksOnASingleLine: Empty
ClosedPublic

Authored by MyDeveloperDay on Dec 15 2021, 4:06 AM.

Details

Summary

https://github.com/llvm/llvm-project/issues/52715

Fixes #52715

AllowShortBlocksOnASingleLine seems to never be checked for "Empty" as such if its used it will be considered "Always" as we only ever check AllowShortBlocksOnASingleLine != Never

This impacts C++ as well as C# hence the slightly duplicated test.

Diff Detail

Unit TestsFailed

Event Timeline

MyDeveloperDay requested review of this revision.Dec 15 2021, 4:06 AM
MyDeveloperDay created this revision.
jbcoe accepted this revision.Dec 15 2021, 4:43 AM
This revision is now accepted and ready to land.Dec 15 2021, 4:43 AM
curdeius accepted this revision.Dec 15 2021, 6:02 AM

LGTM.

This revision was landed with ongoing or failed builds.Dec 15 2021, 3:07 PM
This revision was automatically updated to reflect the committed changes.