[SimplifyCFG] Try to do somethink with misscompile bug in widenable condition.

[dbakunevich]

Summary

When working with optimizations on widenable condition, a misscompile bug was found.
@mkazantsev tried to fix the bug by limiting one of the transforms, but this transforms is a weird, but a legal form of guard widening. He doesn't have strong enough ground to disable it.
So maybe the only way to break the infinite loop here is just to break while-loop after N iterations.
Link to Maxim's patch https://reviews.llvm.org/D112693

[lebedev.ri]

Semi-weak -1
Test?

[dbakunevich]

In D115781#3194271, @lebedev.ri wrote:

Semi-weak -1
Test?

I updated this patch. Updated old test written by Max Kazantsev.
Need I wrote one more test for my patch?

[mkazantsev]

Please rewrite commit message here to make it clear what's going on.

The point here is that I tried to fix the hang by limiting one of the transforms. But as it was pointed out on review, this transform is a weird, but legal form of guard widening. So I don't have strong enough ground to disable it.

On the other hand, there are 3 unrelated transforms described in D112693 that lead to infinite loop.

I can' say either of them is illegal, and there is no clear invariant set that one of them would break. So maybe the only way to break the infinite loop here is just to break while-loop after N interations.

[lebedev.ri]

D112693 made it sound like the actual problem is in the front-end.

llvm/lib/Transforms/Scalar/SimplifyCFGPass.cpp

for (unsigned i = 0, e = Edges.size(); i != e; ++i)
     UniqueLoopHeaders.insert(const_cast<BasicBlock *>(Edges[i].second));
 
   SmallVector<WeakVH, 16> LoopHeaders(UniqueLoopHeaders.begin(),
                                       UniqueLoopHeaders.end());
 
   unsigned IterCnt = 0;
   (void)IterCnt;
   while (LocalChange) {
-    assert(IterCnt++ < 1000 && "Iterative simplification didn't converge!");
+    if (IterCnt++ > 1000)
+      break;
+    // TODO: Fix infinite loop bug when working with widenable condition.
     LocalChange = false;
 
     // Loop over all of the basic blocks and remove them if they are unneeded.
     for (Function::iterator BBIt = F.begin(); BBIt != F.end(); ) {
       BasicBlock &BB = *BBIt++;
       if (DTU) {
         assert(
             !DTU->isBBPendingDeletion(&BB) &&

llvm/test/Transforms/SimplifyCFG/pr52290.ll

+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
 ; RUN: opt < %s -simplifycfg -S | FileCheck %s
 ; RUN: opt < %s -passes=simplifycfg -S | FileCheck %s
 
-; XFAIL: *
-; REQUIRES: asserts
 ; FIXME: Fails due to infinite loop in iterativelySimplifyCFG.
 
 ; ModuleID = 'test/Transforms/SimplifyCFG/pr-new.ll'
 source_filename = "test/Transforms/SimplifyCFG/pr-new.ll"
 
 define i32 @test(float %arg) gc "statepoint-example" personality i32* ()* @blam {
-; CHECK-LABEL: @test
+; CHECK-LABEL: @test(
+; CHECK-NEXT:  bb:
+; CHECK-NEXT:    [[TMP:%.*]] = call i1 @llvm.experimental.widenable.condition()
+; CHECK-NEXT:    br i1 [[TMP]], label [[BB2:%.*]], label [[BB1:%.*]]
+; CHECK:       bb1:
+; CHECK-NEXT:    br i1 undef, label [[BB7:%.*]], label [[BB5:%.*]]
+; CHECK:       bb2:
+; CHECK-NEXT:    [[TMP3:%.*]] = getelementptr inbounds i8, i8 addrspace(1)* undef, i64 16
+; CHECK-NEXT:    br i1 undef, label [[BB7]], label [[BB4:%.*]]
+; CHECK:       bb4:
+; CHECK-NEXT:    call void @snork() [ "deopt"() ]
+; CHECK-NEXT:    unreachable
+; CHECK:       bb5:
+; CHECK-NEXT:    ret i32 0
+; CHECK:       bb7:
+; CHECK-NEXT:    [[TMP8:%.*]] = call i32 (...) @llvm.experimental.deoptimize.i32(i32 10) [ "deopt"() ]
+; CHECK-NEXT:    ret i32 [[TMP8]]
+;
 bb:
   %tmp = call i1 @llvm.experimental.widenable.condition()
   br i1 %tmp, label %bb2, label %bb1
 
 bb1:                                              ; preds = %bb
   br i1 undef, label %bb7, label %bb5
 
 bb2:                                              ; preds = %bb