[LNT] Fix the global_status page

[kpdev42]

Summary

It seems the page /global_status did not work for years because of few bugs.
This patch fixes this page.

OS Laboratory. Huawei Russian Research Institute. Saint-Petersburg

[thopre]

LGTM otherwise

lnt/server/ui/views.py

1543

./lnt/server/ui/views.py:1543:22: E128 continuation line under-indented for visual indent

[kpdev42]

Fix flake8 "continuation line under-indented for visual indent"

[thopre]

LGTM

lnt/server/ui/views.py

def v4_global_status():
     else:
         # Otherwise, just use today.
         latest_date = datetime.date.today()
 
     # Create a datetime for the day before the most recent run.
     yesterday = latest_date - datetime.timedelta(days=1)
 
     # Get arguments.
-    revision = int(request.args.get('revision',
-                                    ts.Machine.DEFAULT_BASELINE_REVISION))
+    revision = request.args.get('revision',
+                                str(ts.Machine.DEFAULT_BASELINE_REVISION))
     field = fields.get(request.args.get('field', None), metric_fields[0])
 
     # Get the list of all runs we might be interested in.
     recent_runs = session.query(ts.Run) \
         .filter(ts.Run.start_time > yesterday) \
         .all()
 
     # Aggregate the runs by machine.
def v4_global_status():
     # over.
     machine_run_info = []
     reported_run_ids = []
 
     for machine in recent_machines:
         runs = recent_runs_by_machine[machine]
 
         # Get the baseline run for this machine.
-        baseline = machine.get_closest_previously_reported_run(session,
-                                                               revision)
+        baseline = machine.get_closest_previously_reported_run(
+            session, ts.Order(llvm_project_revision=revision))
 
         # Choose the "best" run to report on. We want the most recent one with
         # the most recent order.
         run = max(runs, key=lambda r: (r.order, r.start_time))
         if baseline:
             machine_run_info.append((baseline, run))
             reported_run_ids.append(baseline.id)
         reported_run_ids.append(run.id)
 
+    if not machine_run_info:
+        abort(404, "No closest runs for revision '{}'".format(revision))
+
     # Get the set all tests reported in the recent runs.
     reported_tests = session.query(ts.Test.id, ts.Test.name).filter(
         sqlalchemy.sql.exists('*', sqlalchemy.sql.and_(
             ts.Sample.run_id.in_(reported_run_ids),
             ts.Sample.test_id == ts.Test.id))).all()
 
     # Load all of the runs we are interested in.
     runinfo = lnt.server.reporting.analysis.RunInfo(session, ts,
                                                     reported_run_ids)
 
     # Build the test matrix. This is a two dimensional table index by
     # (machine-index, test-index), where each entry is the percent change.
     test_table = []
     for i, (test_id, test_name) in enumerate(reported_tests):
         # Create the row, starting with the test name and worst entry.
         row = [(test_id, test_name), None]
 
         # Compute comparison results for each machine.
         row.extend((runinfo.get_run_comparison_result(
                         run, baseline, test_id, field,
-                        ts.Sample.get_hash_of_binary_field),
+                        ts.Sample.get_hash_of_binary_field()),
                     run.id)
                    for baseline, run in machine_run_info)
 
         # Compute the worst cell value.
         if len(row) > 2:
             row[1] = max(cr.pct_delta
                          for cr, _ in row[2:])
 
         test_table.append(row)
 
     # Order the table by worst regression.
-    test_table.sort(key=lambda row: 0 if row[1] is None else row[1], reverse=True)
+    test_table.sort(key=lambda row: row[1], reverse=True)
 
     return render_template("v4_global_status.html",
                            tests=test_table,
                            machines=recent_machines,
                            fields=metric_fields,
                            selected_field=field,
                            selected_revision=revision,
                            **ts_data(ts))
if mem > 1024**3:
         msg = "Over memory " + str(mem) + ">" + str(1024**3)
     if is_bad_state:
         return msg, 500
     return msg, 200
 
 
 @v4_route("/search")
 def v4_search():
-    def _isint(i):
-        try:
-            int(i)
-            return True
-        except Exception:
-            return False
-
     session = request.session
     ts = request.get_testsuite()
     query = request.args.get('q')
     l_arg = request.args.get('l', 8)
     default_machine = request.args.get('m', None)
 
     assert query
     results = lnt.server.db.search.search(session, ts, query,