This is an archive of the discontinued LLVM Phabricator instance.

Differential D115552

[ASan] Added NO_EXEC_STACK_DIRECTIVE to assembly callback file.
ClosedPublic

Authored by kstoimenov on Dec 10 2021, 1:45 PM.

Download Raw Diff

Details

Reviewers

vitalybuka
browneee

Commits

rGda7e9e34104e: [ASan] Added NO_EXEC_STACK_DIRECTIVE to assembly callback file.
rGe31a5e0ba540: [ASan] Added NO_EXEC_STACK_DIRECTIVE to assembly callback file.

Summary

This is present in our assembly files. It should fix decorate_proc_maps.cpp failures because of shadow memory being allocated as executable.

Diff Detail

Repository: rG LLVM Github Monorepo

Unit TestsFailed

	Time	Test
	20,760 ms	x64 debian > ThreadSanitizer-x86_64.Linux::dlopen_static_tls.cpp

Event Timeline

kstoimenov requested review of this revision.Dec 10 2021, 1:45 PM

kstoimenov created this revision.

Herald added a project: Restricted Project. · View Herald TranscriptDec 10 2021, 1:45 PM

Herald added a subscriber: Restricted Project. · View Herald Transcript

kstoimenov added reviewers: vitalybuka, browneee.Dec 10 2021, 1:46 PM

vitalybuka accepted this revision.Dec 10 2021, 1:52 PM

This revision is now accepted and ready to land.Dec 10 2021, 1:52 PM

This revision was landed with ongoing or failed builds.Dec 10 2021, 1:53 PM

Closed by commit rGe31a5e0ba540: [ASan] Added NO_EXEC_STACK_DIRECTIVE to assembly callback file. (authored by kstoimenov). · Explain Why

This revision was automatically updated to reflect the committed changes.

kstoimenov added a commit: rGe31a5e0ba540: [ASan] Added NO_EXEC_STACK_DIRECTIVE to assembly callback file..

Harbormaster completed remote builds in B138730: Diff 393585.Dec 10 2021, 2:02 PM

aeubanks added a reverting change: rGa357fad868f8: Revert "[ASan] Added NO_EXEC_STACK_DIRECTIVE to assembly callback file.".Dec 13 2021, 3:30 PM

aeubanks mentioned this in D114558: [ASan] Shared optimized callbacks implementation..Dec 13 2021, 3:31 PM

vitalybuka added a commit: rGda7e9e34104e: [ASan] Added NO_EXEC_STACK_DIRECTIVE to assembly callback file..Dec 14 2021, 6:34 PM

Revision Contents

Path

Size

compiler-rt/

lib/

asan/

asan_rtl_x86_64.S

2 lines

Diff 393585

compiler-rt/lib/asan/asan_rtl_x86_64.S

	Show First 20 Lines • Show All 135 Lines • ▼ Show 20 Lines
	ASAN_MEMORY_ACCESS_CALLBACKS_ADD(R8)			ASAN_MEMORY_ACCESS_CALLBACKS_ADD(R8)
	ASAN_MEMORY_ACCESS_CALLBACKS_ADD(R9)			ASAN_MEMORY_ACCESS_CALLBACKS_ADD(R9)
	ASAN_MEMORY_ACCESS_CALLBACKS_ADD(R12)			ASAN_MEMORY_ACCESS_CALLBACKS_ADD(R12)
	ASAN_MEMORY_ACCESS_CALLBACKS_ADD(R13)			ASAN_MEMORY_ACCESS_CALLBACKS_ADD(R13)
	ASAN_MEMORY_ACCESS_CALLBACKS_ADD(R14)			ASAN_MEMORY_ACCESS_CALLBACKS_ADD(R14)
	ASAN_MEMORY_ACCESS_CALLBACKS_ADD(R15)			ASAN_MEMORY_ACCESS_CALLBACKS_ADD(R15)

	#endif			#endif

				NO_EXEC_STACK_DIRECTIVE