This is an archive of the discontinued LLVM Phabricator instance.

Differential D115375

[compiler-rt] Disabled tests and benchmarks for libc++
ClosedPublic

Authored by vitalybuka on Dec 8 2021, 12:30 PM.

Details

Reviewers
ldionne
phosek
Commits
rG8de23903e331: [compiler-rt] Disabled tests and benchmarks for libc++
Summary

We don't run tests or benchmarks from this build anyway.
Benchmarks in custom libc++ break my local build.

Diff Detail

Event Timeline

vitalybuka created this revision.Dec 8 2021, 12:30 PM
Herald added subscribers: mgorny, dberris. · View Herald TranscriptDec 8 2021, 12:30 PM
vitalybuka requested review of this revision.Dec 8 2021, 12:30 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 8 2021, 12:30 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
vitalybuka retitled this revision from [compiler-rt] Disabled tests and benchmarks for libc++ We don't run tests or benchmarks from this build anyway. Benchmarks in custom libc++ break my local build. to [compiler-rt] Disabled tests and benchmarks for libc++.Dec 8 2021, 12:31 PM
vitalybuka edited the summary of this revision. (Show Details)
vitalybuka added reviewers: ldionne, phosek.
ldionne accepted this revision.Dec 8 2021, 12:35 PM
This revision is now accepted and ready to land.Dec 8 2021, 12:35 PM
This revision was landed with ongoing or failed builds.Dec 8 2021, 12:44 PM
Closed by commit rG8de23903e331: [compiler-rt] Disabled tests and benchmarks for libc++ (authored by vitalybuka). · Explain Why
This revision was automatically updated to reflect the committed changes.
vitalybuka added a commit: rG8de23903e331: [compiler-rt] Disabled tests and benchmarks for libc++.
Harbormaster completed remote builds in B138239: Diff 392872.Dec 8 2021, 1:48 PM

Revision Contents

PathSize
compiler-rt/
cmake/
Modules/
CustomLibcxx/
2 lines

Diff 392886

compiler-rt/cmake/Modules/CustomLibcxx/CMakeLists.txt

Show All 19 Lines
set(LIBCXX_ENABLE_EXCEPTIONS OFF CACHE BOOL "") set(LIBCXX_ENABLE_EXCEPTIONS OFF CACHE BOOL "")
set(LIBCXX_HERMETIC_STATIC_LIBRARY ON CACHE BOOL "") set(LIBCXX_HERMETIC_STATIC_LIBRARY ON CACHE BOOL "")
# Use above libcxxabi. # Use above libcxxabi.
set(LIBCXX_CXX_ABI "libcxxabi" CACHE STRING "") set(LIBCXX_CXX_ABI "libcxxabi" CACHE STRING "")
set(LIBCXX_CXX_ABI_INTREE 1) set(LIBCXX_CXX_ABI_INTREE 1)
set(LIBCXX_ENABLE_STATIC_ABI_LIBRARY ON CACHE BOOL "") set(LIBCXX_ENABLE_STATIC_ABI_LIBRARY ON CACHE BOOL "")
set(LIBCXX_CXX_ABI_INCLUDE_PATHS ${COMPILER_RT_LIBCXXABI_PATH}/include CACHE PATH "") set(LIBCXX_CXX_ABI_INCLUDE_PATHS ${COMPILER_RT_LIBCXXABI_PATH}/include CACHE PATH "")
set(LIBCXX_INCLUDE_BENCHMARKS OFF CACHE BOOL "")
set(LIBCXX_INCLUDE_TESTS OFF CACHE BOOL "")
add_subdirectory(${COMPILER_RT_LIBCXX_PATH} ${CMAKE_CURRENT_BINARY_DIR}/cxx) add_subdirectory(${COMPILER_RT_LIBCXX_PATH} ${CMAKE_CURRENT_BINARY_DIR}/cxx)