[PowerPC][AIX] Fallback to DAG-ISEL if a global has toc-data attribute.

[sfertile]

Summary

FAST-ISEL should fall back to DAG-ISEL when a global variable has the toc-data attribute. A number of the 64-bit checks were
duplicated in the lit test because of

1. Slightly different output between -O0 and -O2 due to FAST-ISEL vs DAG-ISEL codegen.
2. In preperation of a peephole optimization that will run when optimizations are enabled.

Also updates where we dump the mir since the ppc-ctr-loops-verify pass happens at a different time in the pipeline at -O0 when generating 32-bit code. I

[sfertile]

• Fix if condition that broke the Debian buildbot.
• Remove 'Required: asserts' from the test as I've updated to use a pass that is run regardless of whether asserts are enabled or not.
• Remove some unintended formatting changes from the lit test.

[yoalione]

LGTM

llvm/lib/Target/PowerPC/PPCFastISel.cpp

unsigned PPCFastISel::PPCMaterializeGV(const GlobalValue *GV, MVT VT) {
   // FIXME: Jump tables are not yet required because fast-isel doesn't
   // handle switches; if that changes, we need them as well.  For now,
   // what follows assumes everything's a generic (or TLS) global address.
 
   // FIXME: We don't yet handle the complexity of TLS.
   if (GV->isThreadLocal())
     return 0;
 
+  // If the global has the toc-data attribute then fallback to DAG-ISEL.
+  if (TM.getTargetTriple().isOSAIX())
+    if (const GlobalVariable *Var = dyn_cast_or_null<GlobalVariable>(GV))
+      if (Var->hasAttribute("toc-data"))
+        return false;
+
   PPCFuncInfo->setUsesTOCBasePtr();
   // For small code model, generate a simple TOC load.
   if (CModel == CodeModel::Small)
     BuildMI(*FuncInfo.MBB, FuncInfo.InsertPt, DbgLoc, TII.get(PPC::LDtoc),
             DestReg)
         .addGlobalAddress(GV)
         .addReg(PPC::X2);
   else {

llvm/test/CodeGen/PowerPC/toc-data.ll

-; REQUIRES: asserts
 ; RUN: llc -mtriple powerpc-ibm-aix-xcoff -verify-machineinstrs < %s \
-; RUN:     -stop-before=ppc-ctr-loops-verify | FileCheck %s --check-prefix CHECK32
+; RUN:     -stop-before=ppc-vsx-copy | FileCheck %s --check-prefix CHECK32
 ; RUN: llc -mtriple powerpc64-ibm-aix-xcoff -verify-machineinstrs < %s \
-; RUN:     -stop-before=ppc-ctr-loops-verify | FileCheck %s --check-prefix CHECK64
+; RUN:     -stop-before=ppc-vsx-copy | FileCheck %s --check-prefix CHECK64
 ; RUN: llc -mtriple powerpc-ibm-aix-xcoff -verify-machineinstrs < %s | FileCheck %s --check-prefix TEST32
 ; RUN: llc -mtriple powerpc64-ibm-aix-xcoff -verify-machineinstrs < %s | FileCheck %s --check-prefix TEST64
 
+; RUN: llc -mtriple powerpc-ibm-aix-xcoff -verify-machineinstrs < %s \
+; RUN:     -stop-before=ppc-vsx-copy -O0  | FileCheck %s --check-prefix CHECK32
+; RUN: llc -mtriple powerpc64-ibm-aix-xcoff -verify-machineinstrs < %s \
+; RUN:     -stop-before=ppc-vsx-copy -O0 | FileCheck %s --check-prefix CHECK64-NOOPT
+; RUN: llc -mtriple powerpc-ibm-aix-xcoff -verify-machineinstrs -O0 < %s | FileCheck %s --check-prefix TEST32
+; RUN: llc -mtriple powerpc64-ibm-aix-xcoff -verify-machineinstrs -O0 < %s | FileCheck %s --check-prefix TEST64
+
 @i = dso_local global i32 0, align 4 #0
 @d = dso_local local_unnamed_addr global double 3.141590e+00, align 8
 @f = dso_local local_unnamed_addr global float 0x4005BE76C0000000, align 4 #0
 @ll = dso_local local_unnamed_addr global i64 55, align 8
 @ilocal = internal global i32 0, align 4
 
 define dso_local void @write_int(i32 signext %in) {
   entry:
     store i32 %in, i32* @i, align 4
     ret void
 }
 ; CHECK32: name:            write_int
 ; CHECK32:      %[[SCRATCH:[0-9]+]]:gprc_and_gprc_nor0 = ADDItoc @i, $r2
 ; CHECK32-NEXT: STW %{{[0-9]+}}, 0, killed %[[SCRATCH]] :: (store (s32) into @i)
 
 ; TEST32:         .write_int:
 ; TEST32:           la 4, i[TD](2)
 ; TEST32-NEXT:      stw 3, 0(4)
 
 ; CHECK64: name:            write_int
 ; CHECK64:      %[[SCRATCH:[0-9]+]]:g8rc_and_g8rc_nox0 = ADDItoc8 @i, $x2
 ; CHECK64-NEXT: STW8 %{{[0-9]+}}, 0, killed %[[SCRATCH]] :: (store (s32) into @i)
 
+; CHECK64-NOOPT:  name: write_int
+; CHECK64-NOOPT:    %[[SUBREG:[0-9]+]]:gprc = COPY %{{[0-9]}}.sub_32
+; CHECK64-NOOPT:    %[[ADDR:[0-9]+]]:g8rc_and_g8rc_nox0 = ADDItoc8 @i, $x2 :: (load (s64) from got)
+; CHECK64-NOOPT:    STW %[[SUBREG]], 0, killed %[[ADDR]] :: (store (s32) into @i)
+
 ; TEST64:         .write_int:
 ; TEST64:           la 4, i[TD](2)
 ; TEST64-NEXT:      stw 3, 0(4)
 
 
 define dso_local i64 @read_ll() {
   entry:
     %0 = load i64, i64* @ll, align 8
     ret i64 %0
 }
 ; CHECK32: name:            read_ll
 ; CHECK32: LWZtoc @ll, $r2 :: (load (s32) from got)
 
 ; TEST32:       .read_ll:
 ; TEST32:         lwz 4, L..C0(2)
 ; TEST32-NEXT:    lwz 3, 0(4)
 ; TEST32-NEXT:    lwz 4, 4(4)
 
 ; CHECK64: name:            read_ll
-; CHECK64: LDtoc @ll, $x2 :: (load (s64) from got)
+; CHECK64:   %[[SCRATCH:[0-9]+]]:g8rc_and_g8rc_nox0 = LDtoc @ll, $x2 :: (load (s64) from got)
+; CHECK64:   LD 0, killed %[[SCRATCH]]
+
+; CHECK64-NOOPT: name:            read_ll
+; CHECK64-NOOPT:   %[[SCRATCH:[0-9]+]]:g8rc_and_g8rc_nox0 = LDtoc @ll, $x2
+; CHECK64-NOOPT:   LD 0, %[[SCRATCH]]
 
 ; TEST64:       .read_ll:
 ; TEST64:         ld 3, L..C0(2)
 ; TEST64-NEXT:    ld 3, 0(3)
 
 
 define dso_local float @read_float() {
   entry:
     %0 = load float, float* @f, align 4
     ret float %0
 }
 ; CHECK32: name:            read_float
 ; CHECK32: %[[SCRATCH:[0-9]+]]:gprc_and_gprc_nor0 = ADDItoc @f, $r2
 ; CHECK32: %{{[0-9]+}}:f4rc = LFS 0, killed %[[SCRATCH]] :: (dereferenceable load (s32) from @f)
 
 ; TEST32:       .read_float:
 ; TEST32:         la 3, f[TD](2)
 ; TEST32-NEXT:    lfs 1, 0(3)
 
 ; CHECK64: name:            read_float
 ; CHECK64: %[[SCRATCH:[0-9]+]]:g8rc_and_g8rc_nox0 = ADDItoc8 @f, $x2
 ; CHECK64: %{{[0-9]+}}:f4rc = LFS 0, killed %[[SCRATCH]] :: (dereferenceable load (s32) from @f)
 
+; CHECK64-NOOPT: name:            read_float
+; CHECK64-NOOPT:   %[[SCRATCH:[0-9]+]]:g8rc_and_g8rc_nox0 = ADDItoc8 @f, $x2
+; CHECK64-NOOPT:   %{{[0-9]+}}:f4rc = LFS 0, killed %[[SCRATCH]]
+
 ; TEST64:       .read_float:
 ; TEST64:         la 3, f[TD](2)
 ; TEST64-NEXT:    lfs 1, 0(3)
 
 
 define dso_local void @write_double(double %in) {
   entry:
     store double %in, double* @d, align 8
     ret void
 }
 ; CHECK32: name:            write_double
 ; CHECK32: LWZtoc @d, $r2 :: (load (s32) from got)
 
 ; TEST32:       .write_double
 ; TEST32:         lwz 3, L..C1(2)
 ; TEST32-NEXT:    stfd 1, 0(3)
 
 ; CHECK64: name:            write_double
-; CHECK64: LDtoc @d, $x2 :: (load (s64) from got)
+; CHECK64:   %[[SCRATCH:[0-9]+]]:g8rc_and_g8rc_nox0 = LDtoc @d, $x2 :: (load (s64) from got)
+; CHECK64:   STFD %{{[0-9]+}}, 0, killed %[[SCRATCH]]
+
+; CHECK64-NOOPT: name:            write_double
+; CHECK64-NOOPT:   %[[SCRATCH:[0-9]+]]:g8rc_and_g8rc_nox0 = LDtoc @d, $x2
+; CHECK64-NOOPT    STFD %{{[0-9]+}}, 0 %[[SCRATCH]]
 
 ; TEST64:       .write_double
 ; TEST64:         ld 3, L..C1(2)
 ; TEST64-NEXT:    stfd 1, 0(3)
 
 
 define dso_local nonnull i32* @addr() {
   entry:
     ret i32* @i
 }
 ; CHECK32: name:            addr
 ; CHECK32:       %[[SCRATCH:[0-9]+]]:gprc = ADDItoc @i, $r2
 ; CHECK32-NEXT:  $r3 = COPY %[[SCRATCH]]
 
 ; TEST32:       .addr
 ; TEST32:         la 3, i[TD](2)
 
 ; CHECK64: name:            addr
 ; CHECK64:       %[[SCRATCH:[0-9]+]]:g8rc = ADDItoc8 @i, $x2
 ; CHECK64-NEXT:  $x3 = COPY %[[SCRATCH]]
 
+; CHECK64-NOOPT: name:            addr
+; CHECK64-NOOPT:   %[[SCRATCH:[0-9]+]]:g8rc = ADDItoc8 @i, $x2
+; CHECK64-NOOPT:   $x3 = COPY %[[SCRATCH]]
+
 ; TEST64:       .addr
 ; TEST64:         la 3, i[TD](2)
 
 ; TEST32:         .toc
 ; TEST32:           .tc ll[TC],ll[RW]
 ; TEST32-NOT:       .csect ll[TD]
 ; TEST32:           .tc d[TC],d[RW]
 ; TEST32-NOT:       .csect d[TD],2