This is an archive of the discontinued LLVM Phabricator instance.

Differential D115316

Build MLIR with -Werror=mismatched-tags (NFC)
ClosedPublic

Authored by mehdi_amini on Dec 7 2021, 9:14 PM.

Details

Reviewers
rriddle
Commits
rG3bed2a7212ce: Build MLIR with -Werror=mismatched-tags (NFC)
Summary

This is a defensive action to catch at build time on Linux failures that
may happen only on Windows otherwise.

Diff Detail

Event Timeline

mehdi_amini created this revision.Dec 7 2021, 9:14 PM
Herald added subscribers: sdasgup3, wenzhicui, wrengr and 19 others. · View Herald TranscriptDec 7 2021, 9:14 PM
mehdi_amini requested review of this revision.Dec 7 2021, 9:14 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 7 2021, 9:14 PM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
Harbormaster completed remote builds in B138072: Diff 392639.Dec 7 2021, 9:44 PM
rriddle accepted this revision.Dec 7 2021, 9:56 PM
This revision is now accepted and ready to land.Dec 7 2021, 9:56 PM
Closed by commit rG3bed2a7212ce: Build MLIR with -Werror=mismatched-tags (NFC) (authored by mehdi_amini). · Explain WhyDec 7 2021, 9:59 PM
This revision was automatically updated to reflect the committed changes.
mehdi_amini added a commit: rG3bed2a7212ce: Build MLIR with -Werror=mismatched-tags (NFC).

Revision Contents

PathSize
mlir/
7 lines

Diff 392646

mlir/CMakeLists.txt

Show First 20 Lines • Show All 42 Lines • ▼ Show 20 Lines message(FATAL_ERROR " MLIR does not support `-Bsymbolic` (see http://llvm.org/pr51420 ),"
" try `-Bsymbolic-functions` instead.") " try `-Bsymbolic-functions` instead.")
endif() endif()
# Forbid implicit function declaration: this may lead to subtle bugs and we # Forbid implicit function declaration: this may lead to subtle bugs and we
# don't have a reason to support this. # don't have a reason to support this.
check_c_compiler_flag("-Werror=implicit-function-declaration" C_SUPPORTS_WERROR_IMPLICIT_FUNCTION_DECLARATION) check_c_compiler_flag("-Werror=implicit-function-declaration" C_SUPPORTS_WERROR_IMPLICIT_FUNCTION_DECLARATION)
append_if(C_SUPPORTS_WERROR_IMPLICIT_FUNCTION_DECLARATION "-Werror=implicit-function-declaration" CMAKE_C_FLAGS) append_if(C_SUPPORTS_WERROR_IMPLICIT_FUNCTION_DECLARATION "-Werror=implicit-function-declaration" CMAKE_C_FLAGS)
# Forbid mismatch between declaration and definition for class vs struct. This is
# harmless on Unix systems, but it'll be a ticking bomb for MSVC/Windows systems
# where it creeps into the ABI.
check_c_compiler_flag("-Werror=mismatched-tags" C_SUPPORTS_WERROR_MISMATCHED_TAGS)
append_if(C_SUPPORTS_WERROR_MISMATCHED_TAGS "-Werror=mismatched-tags" CMAKE_C_FLAGS)
append_if(C_SUPPORTS_WERROR_MISMATCHED_TAGS "-Werror=mismatched-tags" CMAKE_CXX_FLAGS)
# Installing the headers and docs needs to depend on generating any public # Installing the headers and docs needs to depend on generating any public
# tablegen'd targets. # tablegen'd targets.
# mlir-generic-headers are dialect-independent. # mlir-generic-headers are dialect-independent.
add_custom_target(mlir-generic-headers) add_custom_target(mlir-generic-headers)
set_target_properties(mlir-generic-headers PROPERTIES FOLDER "Misc") set_target_properties(mlir-generic-headers PROPERTIES FOLDER "Misc")
# mlir-headers may be dialect-dependent. # mlir-headers may be dialect-dependent.
add_custom_target(mlir-headers) add_custom_target(mlir-headers)
set_target_properties(mlir-headers PROPERTIES FOLDER "Misc") set_target_properties(mlir-headers PROPERTIES FOLDER "Misc")
▲ Show 20 Lines • Show All 132 Lines • Show Last 20 Lines