This is an archive of the discontinued LLVM Phabricator instance.

Differential D115287

[DWARF] Fix consistency and AIX compatibility of checks in DWARF test
ClosedPublic

Authored by Jake-Egan on Dec 7 2021, 2:18 PM.

Details

Reviewers
dblaikie
shchenz
Commits
rGb73cf6207efa: [DWARF] Fix consistency and AIX compatibility of checks in DWARF test
Summary

This patch removes the white space and trailing bracket to make the checks consistent and verbose direct/indirect string agnostic for AIX compatibility.

Diff Detail

Event Timeline

Jake-Egan requested review of this revision.Dec 7 2021, 2:18 PM
Jake-Egan created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptDec 7 2021, 2:18 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Jake-Egan edited the summary of this revision. (Show Details)Dec 7 2021, 2:21 PM
Jake-Egan added a reviewer: dblaikie.
Jake-Egan added a reviewer: shchenz.Dec 7 2021, 2:24 PM
dblaikie accepted this revision.Dec 7 2021, 2:30 PM

Looks good, thanks! (this is for more AIX compatibility so the test is agnostic to strp V str encoding, right? Might be worth noting that in the commit message)

This revision is now accepted and ready to land.Dec 7 2021, 2:30 PM
Harbormaster completed remote builds in B137999: Diff 392536.Dec 7 2021, 3:07 PM
Jake-Egan added a comment.Dec 7 2021, 8:19 PM
In D115287#3177699, @dblaikie wrote:

Looks good, thanks! (this is for more AIX compatibility so the test is agnostic to strp V str encoding, right? Might be worth noting that in the commit message)

Yes, same reasoning as D112636. I will update the commit message. Thanks for the review.

Jake-Egan retitled this revision from [DWARF] Fix consistency of checks in DWARF test to [DWARF] Fix consistency and AIX compatibility of checks in DWARF test.Dec 7 2021, 8:25 PM
Jake-Egan edited the summary of this revision. (Show Details)
Jake-Egan edited the summary of this revision. (Show Details)Dec 7 2021, 8:29 PM
This revision was landed with ongoing or failed builds.Dec 8 2021, 7:10 AM
Closed by commit rGb73cf6207efa: [DWARF] Fix consistency and AIX compatibility of checks in DWARF test (authored by Jake-Egan). · Explain Why
This revision was automatically updated to reflect the committed changes.
Jake-Egan added a commit: rGb73cf6207efa: [DWARF] Fix consistency and AIX compatibility of checks in DWARF test.

Revision Contents

PathSize
llvm/
test/
DebugInfo/
Generic/
2 lines

Diff 392760

llvm/test/DebugInfo/Generic/debug-info-qualifiers.ll

Show All 15 Lines
; RUN: %llc_dwarf -filetype=obj -O0 < %s | llvm-dwarfdump -v - | FileCheck %s ; RUN: %llc_dwarf -filetype=obj -O0 < %s | llvm-dwarfdump -v - | FileCheck %s
; CHECK: DW_TAG_subroutine_type DW_CHILDREN_yes ; CHECK: DW_TAG_subroutine_type DW_CHILDREN_yes
; CHECK-NEXT: DW_AT_reference DW_FORM_flag_present ; CHECK-NEXT: DW_AT_reference DW_FORM_flag_present
; CHECK: DW_TAG_subroutine_type DW_CHILDREN_yes ; CHECK: DW_TAG_subroutine_type DW_CHILDREN_yes
; CHECK-NEXT: DW_AT_rvalue_reference DW_FORM_flag_present ; CHECK-NEXT: DW_AT_rvalue_reference DW_FORM_flag_present
; CHECK: DW_TAG_subprogram ; CHECK: DW_TAG_subprogram
; CHECK-NOT: DW_TAG_subprogram ; CHECK-NOT: DW_TAG_subprogram
; CHECK: DW_AT_name {{.*}} "g") ; CHECK: DW_AT_name {{.*}}"g"
; ;
; CHECK: DW_TAG_subprogram ; CHECK: DW_TAG_subprogram
; CHECK-NOT: DW_TAG_subprogram ; CHECK-NOT: DW_TAG_subprogram
; CHECK: DW_AT_name {{.*}}"l" ; CHECK: DW_AT_name {{.*}}"l"
; CHECK-NOT: DW_TAG_subprogram ; CHECK-NOT: DW_TAG_subprogram
; CHECK: DW_AT_reference [DW_FORM_flag_present] (true) ; CHECK: DW_AT_reference [DW_FORM_flag_present] (true)
; CHECK: DW_TAG_subprogram ; CHECK: DW_TAG_subprogram
▲ Show 20 Lines • Show All 68 Lines • Show Last 20 Lines