Page MenuHomePhabricator

[DWARF] Fix consistency and AIX compatibility of checks in DWARF test
ClosedPublic

Authored by Jake-Egan on Dec 7 2021, 2:18 PM.

Details

Summary

This patch removes the white space and trailing bracket to make the checks consistent and verbose direct/indirect string agnostic for AIX compatibility.

Diff Detail

Event Timeline

Jake-Egan requested review of this revision.Dec 7 2021, 2:18 PM
Jake-Egan created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptDec 7 2021, 2:18 PM
Jake-Egan edited the summary of this revision. (Show Details)Dec 7 2021, 2:21 PM
Jake-Egan added a reviewer: dblaikie.
dblaikie accepted this revision.Dec 7 2021, 2:30 PM

Looks good, thanks! (this is for more AIX compatibility so the test is agnostic to strp V str encoding, right? Might be worth noting that in the commit message)

This revision is now accepted and ready to land.Dec 7 2021, 2:30 PM

Looks good, thanks! (this is for more AIX compatibility so the test is agnostic to strp V str encoding, right? Might be worth noting that in the commit message)

Yes, same reasoning as D112636. I will update the commit message. Thanks for the review.

Jake-Egan retitled this revision from [DWARF] Fix consistency of checks in DWARF test to [DWARF] Fix consistency and AIX compatibility of checks in DWARF test.Dec 7 2021, 8:25 PM
Jake-Egan edited the summary of this revision. (Show Details)
Jake-Egan edited the summary of this revision. (Show Details)Dec 7 2021, 8:29 PM
This revision was landed with ongoing or failed builds.Dec 8 2021, 7:10 AM
This revision was automatically updated to reflect the committed changes.