This is an archive of the discontinued LLVM Phabricator instance.

Differential D115285

[test-suite][AIX] Disable SingleSource/UnitTests/2007-04-25-weak on AIX.
ClosedPublic

Authored by amyk on Dec 7 2021, 1:57 PM.

Details

Reviewers
hubert.reinterpretcast
daltenty
ZarkoCA
Commits
rT9c7e64ebbf94: [test-suite][AIX] Disable SingleSource/UnitTests/2007-04-25-weak on AIX.
Summary

For input into the static linker, it is not possible to encode within an XCOFF object file
that the symbol is to be weakly linked. The AIX mechanism for symbols that may remain
unresolved after initial runtime linking requires the link step to be modified.
Additionally, the resolution of such deferred imports is less automatic on AIX.

As such, SingleSource/UnitTests/2007-04-25-weak test is currently not expected to
pass on AIX, so this patch disables building it and running on AIX.

Diff Detail

Repository
rT test-suite

Event Timeline

amyk created this revision.Dec 7 2021, 1:57 PM
Herald added a subscriber: mgorny. · View Herald TranscriptDec 7 2021, 1:57 PM
amyk requested review of this revision.Dec 7 2021, 1:57 PM
ZarkoCA added a comment.Dec 8 2021, 1:14 PM

The change seems fine but would you mind adding the reason why this test is not expected to pass on AIX in the description?

amyk edited the summary of this revision. (Show Details)Dec 10 2021, 12:01 PM
In D115285#3180820, @ZarkoCA wrote:

The change seems fine but would you mind adding the reason why this test is not expected to pass on AIX in the description?

Thanks @ZarkoCA. I've updated the description and hopefully it is more clear. FYI @hubert.reinterpretcast.

ZarkoCA accepted this revision.Dec 10 2021, 1:14 PM

Thanks, LGTM.

This revision is now accepted and ready to land.Dec 10 2021, 1:14 PM
Closed by commit rT9c7e64ebbf94: [test-suite][AIX] Disable SingleSource/UnitTests/2007-04-25-weak on AIX. (authored by amyk). · Explain WhyJan 29 2022, 7:22 AM
This revision was automatically updated to reflect the committed changes.
amyk added a commit: rT9c7e64ebbf94: [test-suite][AIX] Disable SingleSource/UnitTests/2007-04-25-weak on AIX..

Revision Contents

PathSize
SingleSource/
UnitTests/
7 lines

Diff 404266

SingleSource/UnitTests/CMakeLists.txt

include(CheckCCompilerFlag) include(CheckCCompilerFlag)
add_subdirectory(C++11) add_subdirectory(C++11)
add_subdirectory(Float) add_subdirectory(Float)
add_subdirectory(SignlessTypes) add_subdirectory(SignlessTypes)
add_subdirectory(Threads) add_subdirectory(Threads)
add_subdirectory(Vector) add_subdirectory(Vector)
add_subdirectory(Vectorizer) add_subdirectory(Vectorizer)
# FIXME: Disable SJLJ tests for now, until EH edges are represented. # FIXME: Disable SJLJ tests for now, until EH edges are represented.
# add_subdirectory(SetjmpLongjmp) # add_subdirectory(SetjmpLongjmp)
if(TARGET_OS STREQUAL "Darwin") if(TARGET_OS STREQUAL "Darwin")
add_subdirectory(ObjC) add_subdirectory(ObjC)
add_subdirectory(ObjC++) add_subdirectory(ObjC++)
endif() endif()
file(GLOB Source RELATIVE ${CMAKE_CURRENT_SOURCE_DIR} *.c *.cpp) file(GLOB Source RELATIVE ${CMAKE_CURRENT_SOURCE_DIR} *.c *.cpp)
if(TARGET_OS STREQUAL "AIX" AND ARCH STREQUAL "PowerPC" AND NOT PPC_IS_PPC64_ENABLED) if(TARGET_OS STREQUAL "AIX" AND ARCH STREQUAL "PowerPC")
list(REMOVE_ITEM Source 2007-04-25-weak.c)
if (NOT PPC_IS_PPC64_ENABLED)
list(REMOVE_ITEM Source AtomicOps.c) list(REMOVE_ITEM Source AtomicOps.c)
endif() endif()
endif()
if(TARGET_OS STREQUAL "Darwin") if(TARGET_OS STREQUAL "Darwin")
list(REMOVE_ITEM Source 2007-04-25-weak.c) list(REMOVE_ITEM Source 2007-04-25-weak.c)
if(ARCH STREQUAL "PowerPC") if(ARCH STREQUAL "PowerPC")
list(REMOVE_ITEM Source AtomicOps.c) list(REMOVE_ITEM Source AtomicOps.c)
endif() endif()
endif() endif()
if(ARCH STREQUAL "AArch64") if(ARCH STREQUAL "AArch64")
list(REMOVE_ITEM Source blockstret.c) list(REMOVE_ITEM Source blockstret.c)
Show All 32 Lines