Clang-Tidy implicit bool conversion check use upercase suffixes

[kili]

Summary

Make the type suffix of the implicit bool conversion check upercase. So that the result does not fail the readability uppercase literall suffix check.

[kili]

Fix tests

[njames93]

Something stylistic like this should likely be configurable. Lowercase literals are a part of the language and there is likely a codebase out there that explicitly prefers them

clang-tools-extra/clang-tidy/readability/ImplicitBoolConversionCheck.cpp

AST_MATCHER(Stmt, isNULLMacroExpansion) {
   return isNULLMacroExpansion(&Node, Finder->getASTContext());
 }
 
 StringRef getZeroLiteralToCompareWithForType(CastKind CastExprKind,
                                              QualType Type,
                                              ASTContext &Context) {
   switch (CastExprKind) {
   case CK_IntegralToBoolean:
-    return Type->isUnsignedIntegerType() ? "0u" : "0";
+    return Type->isUnsignedIntegerType() ? "0U" : "0";
 
   case CK_FloatingToBoolean:
-    return Context.hasSameType(Type, Context.FloatTy) ? "0.0f" : "0.0";
+    return Context.hasSameType(Type, Context.FloatTy) ? "0.0F" : "0.0";
 
   case CK_PointerToBoolean:
   case CK_MemberPointerToBoolean: // Fall-through on purpose.
     return Context.getLangOpts().CPlusPlus11 ? "nullptr" : "0";
 
   default:
     llvm_unreachable("Unexpected cast kind");
   }
StringRef getEquivalentForBoolLiteral(const CXXBoolLiteralExpr *BoolLiteral,
   if (!Context.getLangOpts().CPlusPlus11 &&
       (DestType->isPointerType() || DestType->isMemberPointerType()) &&
       BoolLiteral->getValue() == false) {
     return "0";
   }
 
   if (DestType->isFloatingType()) {
     if (Context.hasSameType(DestType, Context.FloatTy)) {
-      return BoolLiteral->getValue() ? "1.0f" : "0.0f";
+      return BoolLiteral->getValue() ? "1.0F" : "0.0F";
     }
     return BoolLiteral->getValue() ? "1.0" : "0.0";
   }
 
   if (DestType->isUnsignedIntegerType()) {
-    return BoolLiteral->getValue() ? "1u" : "0u";
+    return BoolLiteral->getValue() ? "1U" : "0U";
   }
   return BoolLiteral->getValue() ? "1" : "0";
 }
 
 bool isCastAllowedInCondition(const ImplicitCastExpr *Cast,
                               ASTContext &Context) {
   std::queue<const Stmt *> Q;
   Q.push(Cast);