Unify libstdcpp and libcxx formatters for `std::optional`

[zrthxn]

Squash many commits

[wallace]

back to your queue until you get things working

[zrthxn]

Added libcxx support

[wallace]

good job! Only some cosmetic changes are needed and you also need to delete the python code

lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp

774–778

remove this

916–921

same here

948–949

same

lldb/source/Plugins/Language/CPlusPlus/Generic.h

1–2 ↗

(On Diff #392197)

make this one line (=80 chars)

10–11 ↗

(On Diff #392197)

this shouldn't be a comment, and use

LLDB_SOURCE_PLUGINS_LANGUAGE_CPLUSPLUS_GENERIC_H

26 ↗

(On Diff #392197)

LLDB_SOURCE_PLUGINS_LANGUAGE_CPLUSPLUS_GENERIC_H

lldb/source/Plugins/Language/CPlusPlus/GenericOptional.cpp

1–2 ↗

(On Diff #392197)

80 chars

lldb/source/Plugins/Language/CPlusPlus/LibCxxOptional.cpp

78–84 ↗

(On Diff #392197)

delete this entire file

[zrthxn]

Removed old/dead code and commented out sections

[zrthxn]

Cosmetic changes and incorporate requested changes from review

[wallace]

great job!

[wallace]

committed as cfb075089128b2e5918afd0ce21ec10bf455e5ab

lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp

AddCXXSummary(cpp_category_sp, LibcxxContainerSummaryProvider,
                 "libc++ std::tuple summary provider",
                 ConstString("^std::__[[:alnum:]]+::tuple<.*>(( )?&)?$"),
                 stl_summary_flags, true);
   AddCXXSummary(cpp_category_sp,
                 lldb_private::formatters::LibCxxAtomicSummaryProvider,
                 "libc++ std::atomic summary provider",
                 ConstString("^std::__[[:alnum:]]+::atomic<.+>$"),
                 stl_summary_flags, true);
   AddCXXSummary(cpp_category_sp,
                 lldb_private::formatters::LibcxxOptionalSummaryProvider,
                 "libc++ std::optional summary provider",
                 ConstString("^std::__[[:alnum:]]+::optional<.+>(( )?&)?$"),
                 stl_summary_flags, true);
   AddCXXSummary(cpp_category_sp,
                 lldb_private::formatters::LibcxxVariantSummaryProvider,
                 "libc++ std::variant summary provider",
                 ConstString("^std::__[[:alnum:]]+::variant<.+>(( )?&)?$"),
                 stl_summary_flags, true);
 
   stl_summary_flags.SetSkipPointers(true);
 
cpp_category_sp->GetRegexTypeSyntheticsContainer()->Add(
       SyntheticChildrenSP(new ScriptedSyntheticChildren(
           stl_deref_flags,
           "lldb.formatters.cpp.gnu_libstdcpp.StdMapLikeSynthProvider")));
   cpp_category_sp->GetRegexTypeSyntheticsContainer()->Add(
       RegularExpression("^std::multimap<.+> >(( )?&)?$"),
       SyntheticChildrenSP(new ScriptedSyntheticChildren(
           stl_deref_flags,
           "lldb.formatters.cpp.gnu_libstdcpp.StdMapLikeSynthProvider")));
-  cpp_category_sp->GetRegexTypeSyntheticsContainer()->Add(
-      RegularExpression("^std::optional<.+>(( )?&)?$"),
-      SyntheticChildrenSP(new ScriptedSyntheticChildren(
-          stl_synth_flags,
-          "lldb.formatters.cpp.gnu_libstdcpp.StdOptionalSynthProvider")));
+  // cpp_category_sp->GetRegexTypeSyntheticsContainer()->Add(
+  //     RegularExpression("^std::optional<.+>(( )?&)?$"),
+  //     SyntheticChildrenSP(new ScriptedSyntheticChildren(
+  //         stl_synth_flags,
+  //         "lldb.formatters.cpp.gnu_libstdcpp.StdOptionalSynthProvider")));
   cpp_category_sp->GetRegexTypeSyntheticsContainer()->Add(
       RegularExpression("^std::multiset<.+> >(( )?&)?$"),
       SyntheticChildrenSP(new ScriptedSyntheticChildren(
           stl_deref_flags,
           "lldb.formatters.cpp.gnu_libstdcpp.StdMapLikeSynthProvider")));
   cpp_category_sp->GetRegexTypeSyntheticsContainer()->Add(
       RegularExpression("^std::unordered_(multi)?(map|set)<.+> >$"),
       SyntheticChildrenSP(new ScriptedSyntheticChildren(
           stl_deref_flags,
cpp_category_sp->GetRegexTypeSyntheticsContainer()->Add(
           "lldb.formatters.cpp.gnu_libstdcpp.StdForwardListSynthProvider")));
 
   stl_summary_flags.SetDontShowChildren(false);
   stl_summary_flags.SetSkipPointers(false);
   cpp_category_sp->GetRegexTypeSummariesContainer()->Add(
       RegularExpression("^std::optional<.+>(( )?&)?$"),
       TypeSummaryImplSP(new ScriptSummaryFormat(
           stl_summary_flags,
           "lldb.formatters.cpp.gnu_libstdcpp.StdOptionalSummaryProvider")));
   cpp_category_sp->GetRegexTypeSummariesContainer()->Add(
       RegularExpression("^std::bitset<.+>(( )?&)?$"),
       TypeSummaryImplSP(
           new StringSummaryFormat(stl_summary_flags, "size=${svar%#}")));
   cpp_category_sp->GetRegexTypeSummariesContainer()->Add(
       RegularExpression("^std::vector<.+>(( )?&)?$"),
       TypeSummaryImplSP(
           new StringSummaryFormat(stl_summary_flags, "size=${svar%#}")));
   cpp_category_sp->GetRegexTypeSummariesContainer()->Add(