Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

Differential D115137

[formatters] Add a pointer and reference tests for a list and forward_list formatters for libstdcpp and libcxx
ClosedPublic
Actions

Authored by danilashtefan on Dec 6 2021, 1:29 AM.

Details

Reviewers
wallace
Commits
rG6622c1411339: [formatters] Add a pointer and reference tests for a list and forward_list…
Summary

This adds extra tests for libstdcpp and libcxx list and forward_list formatters to check whether formatter behaves correctly when applied on pointer and reference values.

Diff Detail

Event Timeline

danilashtefan requested review of this revision.Dec 6 2021, 1:29 AM
danilashtefan created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptDec 6 2021, 1:29 AM
Herald added a subscriber: lldb-commits. · View Herald Transcript
danilashtefan edited the summary of this revision. (Show Details)Dec 6 2021, 1:31 AM
danilashtefan added a reviewer: wallace.
Herald added a subscriber: JDevlieghere. · View Herald TranscriptDec 6 2021, 1:31 AM
Harbormaster completed remote builds in B137610: Diff 391992.Dec 6 2021, 1:32 AM
wallace accepted this revision.Dec 6 2021, 12:40 PM

thank you!

This revision is now accepted and ready to land.Dec 6 2021, 12:40 PM
Closed by commit rG6622c1411339: [formatters] Add a pointer and reference tests for a list and forward_list… (authored by danilashtefan, committed by Walter Erquinigo <wallace@fb.com>). · Explain WhyDec 6 2021, 1:42 PM
This revision was automatically updated to reflect the committed changes.
Walter Erquinigo <wallace@fb.com> added a commit: rG6622c1411339: [formatters] Add a pointer and reference tests for a list and forward_list….
labath mentioned this in rG88c183e978ed: [lldb] Fix TestDataFormatterGenericList.Dec 8 2021, 4:44 AM

Revision Contents
Changeset List

PathSize
lldb/
source/
Plugins/
Language/
CPlusPlus/
2 lines
test/
API/
functionalities/
data-formatter/
data-formatter-stl/
generic/
forward_list/
90 lines
13 lines
list/
49 lines
11 lines

Diff 392168

View Options

lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp

Loading...
View Options

lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/forward_list/TestDataFormatterGenericForwardList.py

Loading...
View Options

lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/forward_list/main.cpp

Loading...
View Options

lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/list/TestDataFormatterGenericList.py

Loading...
View Options

lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/list/main.cpp

Loading...